You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/08 01:04:11 UTC
[GitHub] [shardingsphere] boyjoy1127 opened a new pull request, #17434: 15827
boyjoy1127 opened a new pull request, #17434:
URL: https://github.com/apache/shardingsphere/pull/17434
Fixes #15827.
Changes proposed in this pull request:
- Add federation result set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu merged pull request #17434: 15827
Posted by GitBox <gi...@apache.org>.
jingshanglu merged PR #17434:
URL: https://github.com/apache/shardingsphere/pull/17434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on pull request #17434: 15827
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on PR #17434:
URL: https://github.com/apache/shardingsphere/pull/17434#issuecomment-1124531083
@boyjoy1127 @strongduanmu Should we create a new branch because it is still in an intermediate state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #17434: 15827
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17434:
URL: https://github.com/apache/shardingsphere/pull/17434#issuecomment-1121959085
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17434?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17434](https://codecov.io/gh/apache/shardingsphere/pull/17434?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (88d7e99) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e24e5e4cce226fdad2035cb50f3f8ab40e1185d1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e24e5e4) will **decrease** coverage by `0.25%`.
> The diff coverage is `0.45%`.
```diff
@@ Coverage Diff @@
## master #17434 +/- ##
============================================
- Coverage 59.07% 58.81% -0.26%
- Complexity 2109 2123 +14
============================================
Files 3551 3564 +13
Lines 53027 53359 +332
Branches 9055 9070 +15
============================================
+ Hits 31325 31385 +60
- Misses 19059 19326 +267
- Partials 2643 2648 +5
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tomized/AbstractUnsupportedOperationResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/17434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9mZWRlcmF0aW9uL2V4ZWN1dG9yL2N1c3RvbWl6ZWQvQWJzdHJhY3RVbnN1cHBvcnRlZE9wZXJhdGlvblJlc3VsdFNldC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...d/AbstractUnsupportedUpdateOperationResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/17434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9mZWRlcmF0aW9uL2V4ZWN1dG9yL2N1c3RvbWl6ZWQvQWJzdHJhY3RVbnN1cHBvcnRlZFVwZGF0ZU9wZXJhdGlvblJlc3VsdFNldC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ation/executor/customized/FederationResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/17434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9mZWRlcmF0aW9uL2V4ZWN1dG9yL2N1c3RvbWl6ZWQvRmVkZXJhdGlvblJlc3VsdFNldC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...federation/executor/customized/WrapperAdapter.java](https://codecov.io/gh/apache/shardingsphere/pull/17434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9mZWRlcmF0aW9uL2V4ZWN1dG9yL2N1c3RvbWl6ZWQvV3JhcHBlckFkYXB0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...result/impl/enumerable/EnumerableMergedResult.java](https://codecov.io/gh/apache/shardingsphere/pull/17434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtbWVyZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL21lcmdlL3Jlc3VsdC9pbXBsL2VudW1lcmFibGUvRW51bWVyYWJsZU1lcmdlZFJlc3VsdC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...cutor/customized/CustomizedFilterableExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/17434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9mZWRlcmF0aW9uL2V4ZWN1dG9yL2N1c3RvbWl6ZWQvQ3VzdG9taXplZEZpbHRlcmFibGVFeGVjdXRvci5qYXZh) | `27.27% <10.00%> (+27.27%)` | :arrow_up: |
| [...ithm/traffic/transaction/JDBCTrafficAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/17434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFmZmljL2FsZ29yaXRobS90cmFmZmljL3RyYW5zYWN0aW9uL0pEQkNUcmFmZmljQWxnb3JpdGhtLmphdmE=) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
| [.../traffic/transaction/FirstSQLTrafficAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/17434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFmZmljL2FsZ29yaXRobS90cmFmZmljL3RyYW5zYWN0aW9uL0ZpcnN0U1FMVHJhZmZpY0FsZ29yaXRobS5qYXZh) | `60.00% <0.00%> (-40.00%)` | :arrow_down: |
| [...balance/RoundRobinTrafficLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/17434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFmZmljL2FsZ29yaXRobS9sb2FkYmFsYW5jZS9Sb3VuZFJvYmluVHJhZmZpY0xvYWRCYWxhbmNlQWxnb3JpdGhtLmphdmE=) | `42.85% <0.00%> (-32.15%)` | :arrow_down: |
| [...balance/RoundRobinReplicaLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/17434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvUm91bmRSb2JpblJlcGxpY2FMb2FkQmFsYW5jZUFsZ29yaXRobS5qYXZh) | `71.42% <0.00%> (-28.58%)` | :arrow_down: |
| ... and [129 more](https://codecov.io/gh/apache/shardingsphere/pull/17434/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17434?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17434?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e24e5e4...88d7e99](https://codecov.io/gh/apache/shardingsphere/pull/17434?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] boyjoy1127 commented on a diff in pull request #17434: 15827
Posted by GitBox <gi...@apache.org>.
boyjoy1127 commented on code in PR #17434:
URL: https://github.com/apache/shardingsphere/pull/17434#discussion_r873157386
##########
shardingsphere-infra/shardingsphere-infra-federation/shardingsphere-infra-federation-executor/src/main/java/org/apache/shardingsphere/infra/federation/executor/customized/AbstractUnsupportedUpdateOperationResultSet.java:
##########
@@ -0,0 +1,451 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.federation.executor.customized;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.sql.Array;
+import java.sql.Blob;
+import java.sql.Clob;
+import java.sql.Date;
+import java.sql.NClob;
+import java.sql.Ref;
+import java.sql.ResultSet;
+import java.sql.RowId;
+import java.sql.SQLException;
+import java.sql.SQLFeatureNotSupportedException;
+import java.sql.SQLXML;
+import java.sql.Time;
+import java.sql.Timestamp;
+
+/**
+ * Unsupported {@code ResultSet} methods.
+ */
+public abstract class AbstractUnsupportedUpdateOperationResultSet extends WrapperAdapter implements ResultSet {
+
+ @Override
+ public final void updateNull(final int columnIndex) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateNull(final String columnLabel) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBoolean(final int columnIndex, final boolean x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBoolean(final String columnLabel, final boolean x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateByte(final int columnIndex, final byte x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateByte(final String columnLabel, final byte x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateShort(final int columnIndex, final short x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateShort(final String columnLabel, final short x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateInt(final int columnIndex, final int x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateInt(final String columnLabel, final int x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateLong(final int columnIndex, final long x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateLong(final String columnLabel, final long x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateFloat(final int columnIndex, final float x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateFloat(final String columnLabel, final float x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateDouble(final int columnIndex, final double x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateDouble(final String columnLabel, final double x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBigDecimal(final int columnIndex, final BigDecimal x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBigDecimal(final String columnLabel, final BigDecimal x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateString(final int columnIndex, final String x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateString(final String columnLabel, final String x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateNString(final int columnIndex, final String nString) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateNString(final String columnLabel, final String nString) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBytes(final int columnIndex, final byte[] x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
Review Comment:
I'm afraid we can't. Because update***() are defined in java.sql.ResultSet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a diff in pull request #17434: 15827
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on code in PR #17434:
URL: https://github.com/apache/shardingsphere/pull/17434#discussion_r870994133
##########
shardingsphere-infra/shardingsphere-infra-federation/shardingsphere-infra-federation-executor/src/main/java/org/apache/shardingsphere/infra/federation/executor/customized/AbstractUnsupportedUpdateOperationResultSet.java:
##########
@@ -0,0 +1,451 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.federation.executor.customized;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.sql.Array;
+import java.sql.Blob;
+import java.sql.Clob;
+import java.sql.Date;
+import java.sql.NClob;
+import java.sql.Ref;
+import java.sql.ResultSet;
+import java.sql.RowId;
+import java.sql.SQLException;
+import java.sql.SQLFeatureNotSupportedException;
+import java.sql.SQLXML;
+import java.sql.Time;
+import java.sql.Timestamp;
+
+/**
+ * Unsupported {@code ResultSet} methods.
+ */
+public abstract class AbstractUnsupportedUpdateOperationResultSet extends WrapperAdapter implements ResultSet {
+
+ @Override
+ public final void updateNull(final int columnIndex) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateNull(final String columnLabel) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBoolean(final int columnIndex, final boolean x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBoolean(final String columnLabel, final boolean x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateByte(final int columnIndex, final byte x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateByte(final String columnLabel, final byte x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateShort(final int columnIndex, final short x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateShort(final String columnLabel, final short x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateInt(final int columnIndex, final int x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateInt(final String columnLabel, final int x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateLong(final int columnIndex, final long x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateLong(final String columnLabel, final long x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateFloat(final int columnIndex, final float x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateFloat(final String columnLabel, final float x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateDouble(final int columnIndex, final double x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateDouble(final String columnLabel, final double x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBigDecimal(final int columnIndex, final BigDecimal x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBigDecimal(final String columnLabel, final BigDecimal x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateString(final int columnIndex, final String x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateString(final String columnLabel, final String x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateNString(final int columnIndex, final String nString) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateNString(final String columnLabel, final String nString) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBytes(final int columnIndex, final byte[] x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
Review Comment:
Is it better to change `updateXXX` to a specific method name?
##########
shardingsphere-infra/shardingsphere-infra-federation/shardingsphere-infra-federation-executor/src/main/java/org/apache/shardingsphere/infra/federation/executor/customized/FederationResultSet.java:
##########
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.federation.executor.customized;
+
+import lombok.AllArgsConstructor;
+import org.apache.shardingsphere.infra.merge.result.MergedResult;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.net.URL;
+import java.sql.Array;
+import java.sql.Blob;
+import java.sql.Clob;
+import java.sql.Date;
+import java.sql.ResultSetMetaData;
+import java.sql.SQLException;
+import java.sql.SQLWarning;
+import java.sql.SQLXML;
+import java.sql.Statement;
+import java.sql.Time;
+import java.sql.Timestamp;
+import java.util.Calendar;
+
+@AllArgsConstructor
+public final class FederationResultSet extends AbstractUnsupportedOperationResultSet {
Review Comment:
`FederationResultSet` is unsupported `ResultSet`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on pull request #17434: 15827
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on PR #17434:
URL: https://github.com/apache/shardingsphere/pull/17434#issuecomment-1128354110
@boyjoy1127 Some IT failed, please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] boyjoy1127 commented on a diff in pull request #17434: 15827
Posted by GitBox <gi...@apache.org>.
boyjoy1127 commented on code in PR #17434:
URL: https://github.com/apache/shardingsphere/pull/17434#discussion_r874271802
##########
shardingsphere-infra/shardingsphere-infra-federation/shardingsphere-infra-federation-executor/src/main/java/org/apache/shardingsphere/infra/federation/executor/customized/AbstractUnsupportedUpdateOperationResultSet.java:
##########
@@ -0,0 +1,451 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.federation.executor.customized;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.sql.Array;
+import java.sql.Blob;
+import java.sql.Clob;
+import java.sql.Date;
+import java.sql.NClob;
+import java.sql.Ref;
+import java.sql.ResultSet;
+import java.sql.RowId;
+import java.sql.SQLException;
+import java.sql.SQLFeatureNotSupportedException;
+import java.sql.SQLXML;
+import java.sql.Time;
+import java.sql.Timestamp;
+
+/**
+ * Unsupported {@code ResultSet} methods.
+ */
+public abstract class AbstractUnsupportedUpdateOperationResultSet extends WrapperAdapter implements ResultSet {
+
+ @Override
+ public final void updateNull(final int columnIndex) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateNull(final String columnLabel) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBoolean(final int columnIndex, final boolean x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBoolean(final String columnLabel, final boolean x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateByte(final int columnIndex, final byte x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateByte(final String columnLabel, final byte x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateShort(final int columnIndex, final short x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateShort(final String columnLabel, final short x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateInt(final int columnIndex, final int x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateInt(final String columnLabel, final int x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateLong(final int columnIndex, final long x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateLong(final String columnLabel, final long x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateFloat(final int columnIndex, final float x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateFloat(final String columnLabel, final float x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateDouble(final int columnIndex, final double x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateDouble(final String columnLabel, final double x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBigDecimal(final int columnIndex, final BigDecimal x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBigDecimal(final String columnLabel, final BigDecimal x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateString(final int columnIndex, final String x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateString(final String columnLabel, final String x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateNString(final int columnIndex, final String nString) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateNString(final String columnLabel, final String nString) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBytes(final int columnIndex, final byte[] x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
Review Comment:
so ga, I'll fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #17434: 15827
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on PR #17434:
URL: https://github.com/apache/shardingsphere/pull/17434#issuecomment-1124560622
> intermediate
@jingshanglu I think it can be split into multiple tasks and merged into master, because the logic of the CustomizedFilterableExecutor branch is currently out of reach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] boyjoy1127 closed pull request #17434: 15827
Posted by GitBox <gi...@apache.org>.
boyjoy1127 closed pull request #17434: 15827
URL: https://github.com/apache/shardingsphere/pull/17434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a diff in pull request #17434: 15827
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on code in PR #17434:
URL: https://github.com/apache/shardingsphere/pull/17434#discussion_r873265741
##########
shardingsphere-infra/shardingsphere-infra-federation/shardingsphere-infra-federation-executor/src/main/java/org/apache/shardingsphere/infra/federation/executor/customized/AbstractUnsupportedUpdateOperationResultSet.java:
##########
@@ -0,0 +1,451 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.federation.executor.customized;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.sql.Array;
+import java.sql.Blob;
+import java.sql.Clob;
+import java.sql.Date;
+import java.sql.NClob;
+import java.sql.Ref;
+import java.sql.ResultSet;
+import java.sql.RowId;
+import java.sql.SQLException;
+import java.sql.SQLFeatureNotSupportedException;
+import java.sql.SQLXML;
+import java.sql.Time;
+import java.sql.Timestamp;
+
+/**
+ * Unsupported {@code ResultSet} methods.
+ */
+public abstract class AbstractUnsupportedUpdateOperationResultSet extends WrapperAdapter implements ResultSet {
+
+ @Override
+ public final void updateNull(final int columnIndex) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateNull(final String columnLabel) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBoolean(final int columnIndex, final boolean x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBoolean(final String columnLabel, final boolean x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateByte(final int columnIndex, final byte x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateByte(final String columnLabel, final byte x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateShort(final int columnIndex, final short x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateShort(final String columnLabel, final short x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateInt(final int columnIndex, final int x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateInt(final String columnLabel, final int x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateLong(final int columnIndex, final long x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateLong(final String columnLabel, final long x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateFloat(final int columnIndex, final float x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateFloat(final String columnLabel, final float x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateDouble(final int columnIndex, final double x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateDouble(final String columnLabel, final double x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBigDecimal(final int columnIndex, final BigDecimal x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBigDecimal(final String columnLabel, final BigDecimal x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateString(final int columnIndex, final String x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateString(final String columnLabel, final String x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateNString(final int columnIndex, final String nString) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateNString(final String columnLabel, final String nString) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
+
+ @Override
+ public final void updateBytes(final int columnIndex, final byte[] x) throws SQLException {
+ throw new SQLFeatureNotSupportedException("updateXXX");
+ }
Review Comment:
> I'm afraid we can't. Because update***() are defined in java.sql.ResultSet.
I mean `updateXXX` in `throw new SQLFeatureNotSupportedException("updateXXX");`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] boyjoy1127 commented on a diff in pull request #17434: 15827
Posted by GitBox <gi...@apache.org>.
boyjoy1127 commented on code in PR #17434:
URL: https://github.com/apache/shardingsphere/pull/17434#discussion_r873158318
##########
shardingsphere-infra/shardingsphere-infra-federation/shardingsphere-infra-federation-executor/src/main/java/org/apache/shardingsphere/infra/federation/executor/customized/FederationResultSet.java:
##########
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.federation.executor.customized;
+
+import lombok.AllArgsConstructor;
+import org.apache.shardingsphere.infra.merge.result.MergedResult;
+
+import java.io.InputStream;
+import java.io.Reader;
+import java.math.BigDecimal;
+import java.net.URL;
+import java.sql.Array;
+import java.sql.Blob;
+import java.sql.Clob;
+import java.sql.Date;
+import java.sql.ResultSetMetaData;
+import java.sql.SQLException;
+import java.sql.SQLWarning;
+import java.sql.SQLXML;
+import java.sql.Statement;
+import java.sql.Time;
+import java.sql.Timestamp;
+import java.util.Calendar;
+
+@AllArgsConstructor
+public final class FederationResultSet extends AbstractUnsupportedOperationResultSet {
Review Comment:
There are too many methods in ResultSet, FederationResultSet only implements some of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org