[GitHub] [airflow] vincbeck opened a new pull request, #27016: Use shutil.move instead of os.rename

[GitBox <gi...@apache.org>]

vincbeck opened a new pull request, #27016:
URL: https://github.com/apache/airflow/pull/27016

   Use `shutil.move` instead of `os.rename`. `os.rename` does not work when source and destination are not in the same file system. This test is failing on my laptop because of that. See error below:
   
   ```
       @contextmanager·[39;49;00m
       def·[39;49;00m move_back·[39;49;00m(old_path, new_path):
   >       os.rename(old_path, new_path)
   E       OSError: [Errno 18] Invalid cross-device link: '/opt/airflow/tests/dags/test_dags_folder.py' -> '/tmp/tmpw_l9ofxp/test_dags_folder.py'
   ```
   
   See https://stackoverflow.com/questions/42392600/oserror-errno-18-invalid-cross-device-link


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #27016: Use shutil.move instead of os.rename

[GitBox <gi...@apache.org>]

potiuk merged PR #27016:
URL: https://github.com/apache/airflow/pull/27016


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org