You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by "krickert (via GitHub)" <gi...@apache.org> on 2026/09/12 15:31:24 UTC
[PR] OPENNLP-1924: Align sources with checkstyle and fail on violations (opennlp-addons)
krickert opened a new pull request, #186:
URL: https://github.com/apache/opennlp-addons/pull/186
Formatting-only pass over all modules so checkstyle passes with failOnViolation set to true, the follow-up named in the pom comment when the repository was prepared for 3.x (#183).
- 404 violations down to zero across 57 files: license headers replaced with the standard ASF block (37 files had older wordings), tabs and indentation corrected to the 2-space offset with 4-space wraps, lines over 110 characters wrapped, imports ordered per CustomImportOrder, whitespace around operators, unused imports removed, missing end-of-file newlines added.
- The four javac warnings from CI are also fixed: two possible 'this' escapes in AdminBoundaryContext (the two getters reached from the constructor are now final), the unchecked conversion in GeoEntityLinker (the raw cast is now typed, with a suppression scoped to that declaration), and the deprecated CachedFeatureGenerator varargs constructor in AuxiliaryInfoTokenNameFinderFactory (the generators are wrapped in AggregatedFeatureGenerator, which is what the varargs constructor did internally).
- No behavior changes. mvn validate exits 0 with violations now fatal, and the full test suite passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OPENNLP-1924: Align sources with checkstyle and fail on violations (opennlp-addons)
Posted by "krickert (via GitHub)" <gi...@apache.org>.
krickert merged PR #186:
URL: https://github.com/apache/opennlp-addons/pull/186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org