You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/16 12:11:48 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #6345: [AIRFLOW-5667] Improve type annotations in GCP

mik-laj commented on a change in pull request #6345: [AIRFLOW-5667] Improve type annotations in GCP
URL: https://github.com/apache/airflow/pull/6345#discussion_r335435939
 
 

 ##########
 File path: airflow/gcp/hooks/tasks.py
 ##########
 @@ -505,14 +507,14 @@ def create_task(
     @GoogleCloudBaseHook.fallback_to_default_project_id
     def get_task(
         self,
-        location,
-        queue_name,
-        task_name,
-        project_id=None,
+        location: str,
+        queue_name: str,
+        task_name: str,
+        project_id: Optional[str] = None,
         response_view=None,
 
 Review comment:
   Why did you miss it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services