You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by laurentgo <gi...@git.apache.org> on 2016/02/17 01:50:56 UTC

[GitHub] drill pull request: DRILL-4390: Uses Resource where Drill favicon ...

GitHub user laurentgo opened a pull request:

    https://github.com/apache/drill/pull/378

    DRILL-4390: Uses Resource where Drill favicon is located for static assets

    Drill Webserver uses the first jar containing a rest/static directory to
    find its static assets. In case of another jar containing this directory, it
    might cause the webserver to return 404 errors.
    
    This configures the server to use the resource containing the Drill favicon
    as the place to look for all static resources.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laurentgo/drill laurent/DRILL-4390

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #378
    
----
commit a97c5506cfa800b37258962a8d049fd1b72852e4
Author: Laurent Goujon <la...@dremio.com>
Date:   2016-02-17T00:47:17Z

    DRILL-4390: Uses Resource where Drill favicon is located for static assets
    
    Drill Webserver uses the first jar containing a rest/static directory to
    find its static assets. In case of another jar containing this directory, it
    might cause the webserver to return 404 errors.
    
    This configures the server to use the resource containing the Drill favicon
    as the place to look for all static resources.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4390: Uses Resource where Drill favicon ...

Posted by jacques-n <gi...@git.apache.org>.
Github user jacques-n commented on the pull request:

    https://github.com/apache/drill/pull/378#issuecomment-185001567
  
    LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-4390: Uses Resource where Drill favicon ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/378


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---