You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/27 12:21:19 UTC

[GitHub] [arrow] zhztheplayer commented on pull request #7030: ARROW-7808: [Java][Dataset] Implement Dataset Java API by JNI to C++

zhztheplayer commented on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-717205959


   Hi @emkornfield @jacques-n , would you please have a review on the latest commit? I've squashed previous commit history into the a single base commit to ease rebasing.
   
   Now there is a new memory pool[1] to reserve JVM direct memory(Bits.java) via JNI. Block size is defaulted to 64KB.
   
   Besides, regarding direct memory maybe it's a thinkable practice to make UnsafeAllocationManager/NettyAllocationManager to depend on the same counter(Bits.java) too. But maybe we can do that in a separate PR.
   
   [1] https://github.com/apache/arrow/pull/7030/commits/5a6be7a8443cafb971efae8e83e88878f6742c12#diff-2111aac8ee579e238fb15d4380f2ea1e2f3e2830da939ec3f07c61dc68038d1fR163-R185


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org