You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by scop <gi...@git.apache.org> on 2015/07/14 12:02:46 UTC

[GitHub] activemq-artemis pull request: Versioned frames

GitHub user scop opened a pull request:

    https://github.com/apache/activemq-artemis/pull/78

    Versioned frames

    After the exception handlers patch, the constructors <code>ActiveMQStompException(String msg)</code> and <code>ActiveMQStompException(int code, String details)</code> seem to be unused. I did not remove them yet because of the curious comment above the latter, and secondarily because I haven't educated myself exactly how the bundle exception mechanism works, if it'd need one of these or what. Comments on that?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scop/activemq-artemis versioned-frames

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #78
    
----
commit 3811196973d6169c4e153721a61cb4afe65d13b4
Author: Ville Skyttä <vi...@iki.fi>
Date:   2015-07-14T08:53:14Z

    Create versioned instead of generic frames from STOMP decoder

commit 292a2214a299d192a84da408f8b10ccab818995a
Author: Ville Skyttä <vi...@iki.fi>
Date:   2015-07-14T09:55:41Z

    Set frame handlers to ActiveMQStompExceptions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Versioned frames

Posted by scop <gi...@git.apache.org>.
Github user scop closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/78


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: Versioned frames

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/78#issuecomment-121245328
  
    this is merged, close it please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---