[jira] [Commented] (SYSTEMML-760) PYDML save function ijv and mm formats use 1-based indexing

["Deron Eriksson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYSTEMML-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328063#comment-15328063 ] 

Deron Eriksson commented on SYSTEMML-760:
-----------------------------------------

I don't know how the binary format is implemented, but it should also be checked.


> PYDML save function ijv and mm formats use 1-based indexing
> -----------------------------------------------------------
>
>                 Key: SYSTEMML-760
>                 URL: https://issues.apache.org/jira/browse/SYSTEMML-760
>             Project: SystemML
>          Issue Type: Task
>          Components: APIs
>            Reporter: Deron Eriksson
>
> PYDML now uses 0-based indexing rather than 1-based indexing. Saving to ivj (text) and mm (matrix market) formats uses 1-based matrices.
> The following code:
> {code}
> m = full("1 2 3 0 0 0 7 8 9 0 0 0", rows=4, cols=3)
> save(m, "m.txt", format="text")
> save(m, "m.mm", format="mm")
> {code}
> generates:
> m.txt:
> {code}
> 1 1 1.0
> 1 2 2.0
> 1 3 3.0
> 3 1 7.0
> 3 2 8.0
> 3 3 9.0
> {code}
> and
> m.mm:
> {code}
> %%MatrixMarket matrix coordinate real general
> 4 3 6
> 1 1 1.0
> 1 2 2.0
> 1 3 3.0
> 3 1 7.0
> 3 2 8.0
> 3 3 9.0
> {code}
> 0-based indexing for m.txt would be:
> {code}
> 0 0 1.0
> 0 1 2.0
> 0 2 3.0
> 2 0 7.0
> 2 1 8.0
> 2 2 9.0
> {code}
> A similar situation would exist for the m.mm file.
> Note: The reading of the matrices should also be 0-based if PYDML is 0-based.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)