[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on code in PR #18721:
URL: https://github.com/apache/doris/pull/18721#discussion_r1168166090


##########
be/src/geo/wkb_parse.cpp:
##########
@@ -43,6 +87,36 @@ GeoParseStatus WkbParse::parse_wkb(std::istream& is, bool isEwkb, GeoShape** sha
     return ctx.parse_status;
 }
 
+WkbParseContext* WkbParse::read_hex(std::istream& is, WkbParseContext* ctx) {
+    // setup input/output stream
+    std::stringstream os(std::ios_base::binary | std::ios_base::in | std::ios_base::out);

Review Comment:
   warning: implicit instantiation of undefined template 'std::basic_stringstream<char>' [clang-diagnostic-error]
   ```cpp
       std::stringstream os(std::ios_base::binary | std::ios_base::in | std::ios_base::out);
                         ^
   ```
   **/usr/include/c++/11/iosfwd:107:** template is declared here
   ```cpp
       class basic_stringstream;
             ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org