[GitHub] [airflow] josh-fell commented on a change in pull request #19923: Fix mypy errors in Microsoft Azure provider

[GitBox <gi...@apache.org>]

josh-fell commented on a change in pull request #19923:
URL: https://github.com/apache/airflow/pull/19923#discussion_r760445384



##########
File path: airflow/providers/microsoft/azure/hooks/data_factory.py
##########
@@ -643,7 +642,7 @@ def wait_for_pipeline_run_status(
             "factory_name": factory_name,
             "resource_group_name": resource_group_name,
         }
-        pipeline_run_status = self.get_pipeline_run_status(**pipeline_run_info)
+        pipeline_run_status = self.get_pipeline_run_status(**pipeline_run_info)  # type: ignore

Review comment:
       ```
   airflow/providers/microsoft/azure/hooks/data_factory.py:671: error: Argument 1 to "get_pipeline_run_status" of "AzureDataFactoryHook" has incompatible type "**Dict[str, Optional[str]]"; expected
   "str"
               pipeline_run_status = self.get_pipeline_run_status(**pipeline_run_info)
   ```
   If I enforce keywords arguments on the `get_pipeline_run_status()` function, mypy doesn't complain. Although, we could always explicitly pass a dictionary rather than using the `**kwargs` syntax.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org