You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/11/16 03:53:35 UTC
[GitHub] zeppelin pull request #1644: [ZEPPELIN-1670] Disabling login button double c...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1644
[ZEPPELIN-1670] Disabling login button double click.
### What is this PR for?
This PR is for preventing double click login button.
### What type of PR is it?
Bug Fix | Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1670
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1670
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1644.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1644
----
commit 0a5e9920407de1b41fd519e172ad2e5b474359b0
Author: astroshim <hs...@nflabs.com>
Date: 2016-11-16T03:45:37Z
represent signing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1644: [ZEPPELIN-1670] Disabling login button double c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1644
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1644: [ZEPPELIN-1670] Disabling login button double click.
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1644
thanks for addressing it! it's quite annoying to have sometimes double click on login if taking sometime indeed. I tested locally and it worked as expected, however CI is failing so may need to check CI and refer to comment above as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1644: [ZEPPELIN-1670] Disabling login button double click.
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1644
@astroshim Thanks for the improvement. Tested and LGTM.
Merge to master if there're no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---