You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/02/11 21:20:48 UTC
[GitHub] [accumulo] karthick-rn opened a new pull request #1506: Make
Accumulo 1.9 compatible with ZK 3.5
karthick-rn opened a new pull request #1506: Make Accumulo 1.9 compatible with ZK 3.5
URL: https://github.com/apache/accumulo/pull/1506
Fix as described in #1503
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] billierinaldi commented on issue #1506: Make Accumulo
1.9 compatible with ZK 3.5
Posted by GitBox <gi...@apache.org>.
billierinaldi commented on issue #1506: Make Accumulo 1.9 compatible with ZK 3.5
URL: https://github.com/apache/accumulo/pull/1506#issuecomment-585300322
We're able to run Accumulo 2.0.0 with ZK 3.5 using fluo-muchos with [this change in accumulo-env.sh](https://github.com/apache/fluo-muchos/blob/282a7cf92c72415877e2956fd78803a74bc57394/ansible/roles/accumulo/templates/accumulo-env.sh#L43-L49). I'm not sure if we'd want to add a change like this to the default accumulo-env.sh in master or if we'd just want to document it. Any thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] ctubbsii commented on issue #1506: Make Accumulo 1.9
compatible with ZK 3.5
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1506: Make Accumulo 1.9 compatible with ZK 3.5
URL: https://github.com/apache/accumulo/pull/1506#issuecomment-585312441
> We're able to run Accumulo 2.0.0 with ZK 3.5 using fluo-muchos with [this change in accumulo-env.sh](https://github.com/apache/fluo-muchos/blob/282a7cf92c72415877e2956fd78803a74bc57394/ansible/roles/accumulo/templates/accumulo-env.sh#L43-L49). I'm not sure if we'd want to add a change like this to the default accumulo-env.sh in master or if we'd just want to document it. Any thoughts?
I think a simpler approach of just adding `${ZOOKEEPER_HOME}/lib` to the existing `CLASSPATH` line would be good for 2.x. Are there any pitfalls to doing something simple like that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] billierinaldi commented on issue #1506: Make Accumulo
1.9 compatible with ZK 3.5
Posted by GitBox <gi...@apache.org>.
billierinaldi commented on issue #1506: Make Accumulo 1.9 compatible with ZK 3.5
URL: https://github.com/apache/accumulo/pull/1506#issuecomment-584876874
Thanks for the patch, @karthick-rn! For the general.classpaths change, we should keep both ZK jar locations on the classpath so that it will work with either 3.5 or 3.4 and earlier versions. (If you look at the rest of the entries for general.classpaths, you can see we have entries for different versions of Hadoop, so there is a precedent for this.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] billierinaldi commented on issue #1506: Make Accumulo
1.9 compatible with ZK 3.5
Posted by GitBox <gi...@apache.org>.
billierinaldi commented on issue #1506: Make Accumulo 1.9 compatible with ZK 3.5
URL: https://github.com/apache/accumulo/pull/1506#issuecomment-585320088
I think that might work. We should test it out to make sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] karthick-rn commented on issue #1506: Make Accumulo 1.9
compatible with ZK 3.5
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on issue #1506: Make Accumulo 1.9 compatible with ZK 3.5
URL: https://github.com/apache/accumulo/pull/1506#issuecomment-584874242
Thanks @ctubbsii. Corrected the branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] ctubbsii merged pull request #1506: Make Accumulo 1.9
compatible with ZK 3.5
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1506: Make Accumulo 1.9 compatible with ZK 3.5
URL: https://github.com/apache/accumulo/pull/1506
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] ctubbsii commented on issue #1506: Make Accumulo 1.9
compatible with ZK 3.5
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1506: Make Accumulo 1.9 compatible with ZK 3.5
URL: https://github.com/apache/accumulo/pull/1506#issuecomment-585328713
> I think that might work. We should test it out to make sure.
Okay. Let's go ahead and merge this in, and that can be a separate issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] ctubbsii commented on issue #1506: Make Accumulo 1.9
compatible with ZK 3.5
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #1506: Make Accumulo 1.9 compatible with ZK 3.5
URL: https://github.com/apache/accumulo/pull/1506#issuecomment-584862942
The title indicates it is for 1.9, but the PR was made against the master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services