Re: Review Request: Automation tests to qualify user provided hostname feature.

[Girish Shilamkar <gi...@clogeny.com>]

> On April 26, 2013, 10:42 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_custom_hostname.py, line 265
> > <https://reviews.apache.org/r/10793/diff/1/?file=284685#file284685line265>
> >
> >     How's this test different from the previous one? Should the setting be false? It looks like you are testing for the negative result?
> 
> Girish Shilamkar wrote:
>     The flag is true but we don't provide the hostname so it should pick up the configured instance name. There are different set of tests where flag is false.
> 
> Prasanna Santhanam wrote:
>     I see now in the comments. Can you change the names of the tests thus?
>     test_01_user_provided_hostname(self)
>     """Test for user provided hostname to an instance
>     """
>     
>     test_02_instancename_from_default_configuration(self)
>     """Test for globally set instancename 
>     """
>     
>     When the tests are run it is hard to distinguish between the tests without this information from the logs output by our testrunner..
>     
>

Fixed.


- Girish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10793/#review19762
-----------------------------------------------------------


On April 26, 2013, 7:14 p.m., Girish Shilamkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10793/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 7:14 p.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and SrikanteswaraRao Talluri.
> 
> 
> Description
> -------
> 
> Automation tests to qualify User provides hostname feature.
> 1. Defines services class
> 2. Test to verify custom hostname for the instance with internal name
> 3. Test to verify custom hostname for the instance without internal name
> 
> 
> This addresses bug CLOUDSTACK-778.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_custom_hostname.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10793/diff/
> 
> 
> Testing
> -------
> 
> Tested and works fine.
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>