You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Michi Mutsuzaki (JIRA)" <ji...@apache.org> on 2010/07/21 09:13:54 UTC
[jira] Created: (ZOOKEEPER-826) cli.c should not call zoo_add_auth
immediately after zookeeper_init()
cli.c should not call zoo_add_auth immediately after zookeeper_init()
----------------------------------------------------------------------
Key: ZOOKEEPER-826
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-826
Project: Zookeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.3.1
Reporter: Michi Mutsuzaki
Priority: Minor
In cli.c, zoo_add_auth() gets called right after zookeeper_init(). Instead, zoo_add_auth() should be called in the callback after the connection is established.
--Michi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-826) cli.c should not call
zoo_add_auth immediately after zookeeper_init()
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890595#action_12890595 ]
Patrick Hunt commented on ZOOKEEPER-826:
----------------------------------------
actually afaik it's ok to do this, the request will be queued. why do you think this is a bug?
> cli.c should not call zoo_add_auth immediately after zookeeper_init()
> ----------------------------------------------------------------------
>
> Key: ZOOKEEPER-826
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-826
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Michi Mutsuzaki
> Priority: Minor
>
> In cli.c, zoo_add_auth() gets called right after zookeeper_init(). Instead, zoo_add_auth() should be called in the callback after the connection is established.
> --Michi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-826) cli.c should not call
zoo_add_auth immediately after zookeeper_init()
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890615#action_12890615 ]
Michi Mutsuzaki commented on ZOOKEEPER-826:
-------------------------------------------
It's related to this ticket:
https://issues.apache.org/jira/browse/ZOOKEEPER-800
Inside zoo_add_auth() function, send_last_auth_info() gets called if the handle is in ZOO_CONNECTED_STATE or ZOO_ASSOCIATING_STATE. However, it doesn't get called if it's in ZOO_CLOSED_STATE, which is usually the case right after zookeeper_init() returns.
--Michi
> cli.c should not call zoo_add_auth immediately after zookeeper_init()
> ----------------------------------------------------------------------
>
> Key: ZOOKEEPER-826
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-826
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Michi Mutsuzaki
> Priority: Minor
>
> In cli.c, zoo_add_auth() gets called right after zookeeper_init(). Instead, zoo_add_auth() should be called in the callback after the connection is established.
> --Michi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.