You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/21 16:54:29 UTC
[GitHub] [tvm] ekalda opened a new pull request #10695: [microNPU] Determine block configs using the cascader
ekalda opened a new pull request #10695:
URL: https://github.com/apache/tvm/pull/10695
The cascader needs to be able to choose the block config for operations in order to accurately model their performance.
The cascader must attach the chosen block config to the te.Schedule. This is done using a pragma. The chosen block config
is also added to the TIR spec. If the cascader hasn't set a block config, it defaults to the existing block config
selection behaviour.
Co-authored-by: Matthew Barrett <Ma...@arm.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on pull request #10695: [microNPU] Determine block configs using the cascader
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on pull request #10695:
URL: https://github.com/apache/tvm/pull/10695#issuecomment-1075325442
Sure :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #10695: [microNPU] Determine block configs using the cascader
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #10695:
URL: https://github.com/apache/tvm/pull/10695#issuecomment-1075331278
Thanks @mbaret @ekalda @lhutton1 @NicolaLancellotti !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ekalda commented on pull request #10695: [microNPU] Determine block configs using the cascader
Posted by GitBox <gi...@apache.org>.
ekalda commented on pull request #10695:
URL: https://github.com/apache/tvm/pull/10695#issuecomment-1074157970
This PR is to supersede https://github.com/apache/tvm/pull/10376 - so https://github.com/apache/tvm/pull/10376 can be closed!
cc: @manupa-arm @lhutton1 @NicolaLancellotti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm merged pull request #10695: [microNPU] Determine block configs using the cascader
Posted by GitBox <gi...@apache.org>.
manupa-arm merged pull request #10695:
URL: https://github.com/apache/tvm/pull/10695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lhutton1 commented on a change in pull request #10695: [microNPU] Determine block configs using the cascader
Posted by GitBox <gi...@apache.org>.
lhutton1 commented on a change in pull request #10695:
URL: https://github.com/apache/tvm/pull/10695#discussion_r831905577
##########
File path: tests/python/contrib/test_ethosu/test_replace_identity.py
##########
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from numpy.core.shape_base import block
Review comment:
Nit: is this used?
##########
File path: tests/python/contrib/test_ethosu/test_codegen.py
##########
@@ -460,7 +460,7 @@ def pooling(x):
op = tf.nn.relu(op)
return op
- _compare_tvm_with_tflite(pooling, [ifm_shape], accel_type)
+ _compare_tvm_with_tflite(pooling, [ifm_shape], accel_type, print_cmm=True)
Review comment:
Nit: do we need to print this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ekalda commented on a change in pull request #10695: [microNPU] Determine block configs using the cascader
Posted by GitBox <gi...@apache.org>.
ekalda commented on a change in pull request #10695:
URL: https://github.com/apache/tvm/pull/10695#discussion_r832332431
##########
File path: tests/python/contrib/test_ethosu/test_replace_identity.py
##########
@@ -14,6 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from numpy.core.shape_base import block
Review comment:
Will remove!
##########
File path: tests/python/contrib/test_ethosu/test_codegen.py
##########
@@ -460,7 +460,7 @@ def pooling(x):
op = tf.nn.relu(op)
return op
- _compare_tvm_with_tflite(pooling, [ifm_shape], accel_type)
+ _compare_tvm_with_tflite(pooling, [ifm_shape], accel_type, print_cmm=True)
Review comment:
Yeah I think it can be removed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org