[GitHub] [incubator-druid] xvrl commented on a change in pull request #8392: Do not assume system classloader is URLClassLoader in Java 9+

[GitBox <gi...@apache.org>]

xvrl commented on a change in pull request #8392: Do not assume system classloader is URLClassLoader in Java 9+
URL: https://github.com/apache/incubator-druid/pull/8392#discussion_r317376241
 
 

 ##########
 File path: processing/src/test/java/org/apache/druid/granularity/QueryGranularityTest.java
 ##########
 @@ -802,17 +800,6 @@ private void assertSameInterval(List<DateTime> expected, Iterable<Interval> actu
     Assert.assertFalse("actualIter not exhausted!?", actualIter.hasNext());
     Assert.assertFalse("expectedIter not exhausted!?", expectedIter.hasNext());
   }
-
-  @Test(timeout = 60_000L)
-  public void testDeadLock() throws Exception
 
 Review comment:
   I thought about it, but I tried to explain why I think this test does not add much value in the PR description. If we feel strongly about it though, we can try to make it work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org