You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/11 22:03:12 UTC

[GitHub] [beam] riteshghorse edited a comment on pull request #15911: [BEAM-13001] collect DoFn metrics for Combine

riteshghorse edited a comment on pull request #15911:
URL: https://github.com/apache/beam/pull/15911#issuecomment-966654496


   Okay, so each of LiftedCombine, MergeAccumulators, and ExtractOutput have to track the ProcessElement's phase in their respective methods. StartBundle and FinishBundle for LiftedCombine however seems to be calling the Combine's method. So for them we have to track their phase in Combine itself. Am I understanding it correct?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org