You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/22 04:04:57 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #14730: [fix][broker]: Fix cannot delete namespace with system topic

codelipenghui commented on a change in pull request #14730:
URL: https://github.com/apache/pulsar/pull/14730#discussion_r831750436



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java
##########
@@ -791,6 +791,11 @@ protected void validateGlobalNamespaceOwnership(NamespaceName namespace) {
 
                     log.warn(msg);
                     validationFuture.completeExceptionally(new RestException(Status.PRECONDITION_FAILED, msg));
+                } else if (policies.deleted) {

Review comment:
       +1
   
   Check the namespace delete or not in advance is more reasonable here, after users deleted a namespace, they should not get errors like "Namespace does not have any clusters configured".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org