You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/06/17 08:52:03 UTC

[GitHub] [drill] pjfanning opened a new pull request, #2574: DRILL-8240: remove Strings.java and add dependency on log4j-api instead

pjfanning opened a new pull request, #2574:
URL: https://github.com/apache/drill/pull/2574

   # [DRILL-8240](https://issues.apache.org/jira/browse/DRILL-8240): remove Strings.java and add dependency on log4j-api instead
   
   ## Description
   
   See DRILL-8240 for full description. Apache Hive depends on some log4j-api code. log4j-api is just the API and not the log4j implementation. We should provide the log4j-api jar when using Hive code.
   
   ## Documentation
   
   None expected.
   
   ## Testing
   
   CI build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre commented on pull request #2574: DRILL-8240: remove Strings.java and add dependency on log4j-api instead

Posted by GitBox <gi...@apache.org>.
cgivre commented on PR #2574:
URL: https://github.com/apache/drill/pull/2574#issuecomment-1159598393

   @pjfanning Would you mind please rebasing on current master, then we'll merge?  Thank you for fixing that unit test. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre merged pull request #2574: DRILL-8240: Remove Strings.java and Add Dependency on log4j-api Instead

Posted by GitBox <gi...@apache.org>.
cgivre merged PR #2574:
URL: https://github.com/apache/drill/pull/2574


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] pjfanning commented on pull request #2574: DRILL-8240: remove Strings.java and add dependency on log4j-api instead

Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #2574:
URL: https://github.com/apache/drill/pull/2574#issuecomment-1159692572

   @cgivre rebase done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org