You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/05/23 05:37:48 UTC

[jira] [Created] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Move build/webapps deeper in directory heirarchy to aid eclipse users
---------------------------------------------------------------------

                 Key: HDFS-1980
                 URL: https://issues.apache.org/jira/browse/HDFS-1980
             Project: Hadoop HDFS
          Issue Type: Improvement
          Components: build
    Affects Versions: 0.22.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon
             Fix For: 0.22.0
         Attachments: hdfs-1980.txt

Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".

If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037721#comment-13037721 ] 

Todd Lipcon commented on HDFS-1980:
-----------------------------------

bq. Why do we need both build/web/webapps and build/webapps, ie can we just have build/web/webapps?

hmm, is build/webapps still used somewhere?

bq. Why not use build.webapps.root.dir below?
oops, I agree.

> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-1980:
------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Committed to trunk and 22, thanks for reviewing, Eli.

> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980-1.patch, hdfs-1980.txt, hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045012#comment-13045012 ] 

Hudson commented on HDFS-1980:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #716 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/716/])
    HDFS-1980. Move build/webapps deeper in the build directory heirarchy to aid eclipse users. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132715
Files : 
* /hadoop/hdfs/trunk/build.xml
* /hadoop/hdfs/trunk/src/c++/libhdfs/tests/test-libhdfs.sh
* /hadoop/hdfs/trunk/bin/hdfs
* /hadoop/hdfs/trunk/src/contrib/hdfsproxy/bin/proxy-util
* /hadoop/hdfs/trunk/src/contrib/hdfsproxy/bin/hdfsproxy
* /hadoop/hdfs/trunk/CHANGES.txt


> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980-1.patch, hdfs-1980.txt, hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040999#comment-13040999 ] 

Hadoop QA commented on HDFS-1980:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12480815/hdfs-1980.txt
  against trunk revision 1128986.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 11 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:


    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/658//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/658//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/658//console

This message is automatically generated.

> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980.txt, hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051039#comment-13051039 ] 

Hudson commented on HDFS-1980:
------------------------------

Integrated in Hadoop-Hdfs-trunk #699 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/699/])
    

> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980-1.patch, hdfs-1980.txt, hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044998#comment-13044998 ] 

Hadoop QA commented on HDFS-1980:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12481589/hdfs-1980-1.patch
  against trunk revision 1132698.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 11 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/718//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/718//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/718//console

This message is automatically generated.

> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980-1.patch, hdfs-1980.txt, hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044962#comment-13044962 ] 

Eli Collins commented on HDFS-1980:
-----------------------------------

The test failure above is unrelated.

> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980-1.patch, hdfs-1980.txt, hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-1980:
------------------------------

    Attachment: hdfs-1980-1.patch

+1

Uploading patch that applies to trunk.

> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980-1.patch, hdfs-1980.txt, hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045209#comment-13045209 ] 

Hudson commented on HDFS-1980:
------------------------------

Integrated in Hadoop-Hdfs-22-branch #62 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/62/])
    HDFS-1980. Move build/webapps deeper in the build directory heirarchy to aid eclipse users. Contributed by Todd Lipcon.

todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132714
Files : 
* /hadoop/hdfs/branches/branch-0.22/src/c++/libhdfs/tests/test-libhdfs.sh
* /hadoop/hdfs/branches/branch-0.22/src/contrib/hdfsproxy/bin/hdfsproxy
* /hadoop/hdfs/branches/branch-0.22/CHANGES.txt
* /hadoop/hdfs/branches/branch-0.22/bin/hdfs
* /hadoop/hdfs/branches/branch-0.22/build.xml
* /hadoop/hdfs/branches/branch-0.22/src/contrib/hdfsproxy/bin/proxy-util


> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980-1.patch, hdfs-1980.txt, hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037718#comment-13037718 ] 

Eli Collins commented on HDFS-1980:
-----------------------------------

Why do we need both build/web/webapps and build/webapps, ie can we just have build/web/webapps?

Why not use build.webapps.root.dir below?

{noformat}
  <library path="${build.webapps}/.." exported="false" />
{noformat}

Btw I normally add the src directory (src/webapps parent) to the classpath instead of the build directory. Agree it's better to address this way. 

> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-1980:
------------------------------

    Attachment: hdfs-1980.txt

With the attached patch, you can run "ant eclipse" and the resulting project will be able to run unit tests with no extra build path configuration.

> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-1980:
------------------------------

    Attachment: hdfs-1980.txt

Updated based on Eli's feedback. Also found some spots in contrib that needed updating.

> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980.txt, hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037730#comment-13037730 ] 

Hadoop QA commented on HDFS-1980:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12480081/hdfs-1980.txt
  against trunk revision 1125879.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.TestDFSStorageStateRecovery

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/610//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/610//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/610//console

This message is automatically generated.

> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-1980) Move build/webapps deeper in directory heirarchy to aid eclipse users

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-1980:
------------------------------

    Status: Patch Available  (was: Open)

> Move build/webapps deeper in directory heirarchy to aid eclipse users
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1980
>                 URL: https://issues.apache.org/jira/browse/HDFS-1980
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-1980.txt
>
>
> Currently in order to successfully run unit tests in Eclipse, you have to add the "build/" directory to the classpath, or else the tests won't be able to find the "webapps" dir. This is really annoying because Eclipse then often confuses the classes in build/classes with the source during operations like "go to definition of class".
> If we move it into another directory, eg build/web/webapps then we can add build/web to the eclipse classpath and have tests work by default without also having two copies of every class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira