You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/04/06 21:53:13 UTC

[jira] Updated: (CASSANDRA-58) Encapsulate Partitioner logic

     [ https://issues.apache.org/jira/browse/CASSANDRA-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-58:
------------------------------------

    Attachment: 0002-consolidate-partition-behavior-in-IPartitioner-so-c.patch

> Encapsulate Partitioner logic
> -----------------------------
>
>                 Key: CASSANDRA-58
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-58
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>         Attachments: 0001-include-conf-on-classpath-during-testing-so-log4j.p.patch, 0002-consolidate-partition-behavior-in-IPartitioner-so-c.patch
>
>
> the codebase is littered with if statements like this
>             PartitionerType pType = StorageService.getPartitionerType();
>             switch( pType )
>             {
>                 case OPHF:
>                     // code for order-preserving hash
>                     break;
>                     
>                 default:
>                     // code for random hash
>                     break;
>             }
> We want to move all of those if statements into Partitioner methods to make maintenance easier and to better ensure correctness.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.