You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Milosz Tylenda (JIRA)" <ji...@apache.org> on 2009/02/01 16:01:59 UTC
[jira] Created: (OPENJPA-887) Assertion oversight in TestLibService
Assertion oversight in TestLibService
-------------------------------------
Key: OPENJPA-887
URL: https://issues.apache.org/jira/browse/OPENJPA-887
Project: OpenJPA
Issue Type: Bug
Affects Versions: 1.3.0, 2.0.0-M1, 2.0.0
Reporter: Milosz Tylenda
Priority: Trivial
There is a small but quite nasty oversight in TestLibService class:
assertNotNull("could not find the reference from " + bName + "'s volunteer status back to " + bName, volunteer.getBorrower() == borrower);
I suspect the intention was to have assertTrue(...). The above compiles because of autoboxing creating a Boolean but the assertion is always true, even if volunteer.getBorrower() != borrower.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-887) Assertion oversight in TestLibService
Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Milosz Tylenda updated OPENJPA-887:
-----------------------------------
Attachment: OPENJPA-887.patch
The patch is attached.
> Assertion oversight in TestLibService
> -------------------------------------
>
> Key: OPENJPA-887
> URL: https://issues.apache.org/jira/browse/OPENJPA-887
> Project: OpenJPA
> Issue Type: Bug
> Affects Versions: 1.3.0, 2.0.0-M1, 2.0.0
> Reporter: Milosz Tylenda
> Priority: Trivial
> Attachments: OPENJPA-887.patch
>
>
> There is a small but quite nasty oversight in TestLibService class:
> assertNotNull("could not find the reference from " + bName + "'s volunteer status back to " + bName, volunteer.getBorrower() == borrower);
> I suspect the intention was to have assertTrue(...). The above compiles because of autoboxing creating a Boolean but the assertion is always true, even if volunteer.getBorrower() != borrower.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-887) Assertion oversight in
TestLibService
Posted by "Michael Dick (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694257#action_12694257 ]
Michael Dick commented on OPENJPA-887:
--------------------------------------
No worries Milosz. I've gone ahead and corrected the svn log settings for both releases.
FWIW you can do this by running the following commands :
$ svn ps -r 759470 --revprop svn:log "OPENJPA-887" https://svn.apache.org/repos/asf/openjpa/trunk
$ svn ps -r 759473 --revprop svn:log "OPENJPA-887" https://svn.apache.org/repos/asf/openjpa/branches/1.3.x/
The SVN FAQ has complete documentation at http://subversion.tigris.org/faq.html#change-log-msg.
Obviously you're not the first to do this ;-)
> Assertion oversight in TestLibService
> -------------------------------------
>
> Key: OPENJPA-887
> URL: https://issues.apache.org/jira/browse/OPENJPA-887
> Project: OpenJPA
> Issue Type: Bug
> Affects Versions: 1.3.0, 2.0.0-M1, 2.0.0
> Reporter: Milosz Tylenda
> Assignee: Milosz Tylenda
> Priority: Trivial
> Fix For: 1.3.0, 2.0.0
>
> Attachments: OPENJPA-887.patch
>
>
> There is a small but quite nasty oversight in TestLibService class:
> assertNotNull("could not find the reference from " + bName + "'s volunteer status back to " + bName, volunteer.getBorrower() == borrower);
> I suspect the intention was to have assertTrue(...). The above compiles because of autoboxing creating a Boolean but the assertion is always true, even if volunteer.getBorrower() != borrower.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OPENJPA-887) Assertion oversight in
TestLibService
Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Milosz Tylenda reassigned OPENJPA-887:
--------------------------------------
Assignee: Milosz Tylenda
> Assertion oversight in TestLibService
> -------------------------------------
>
> Key: OPENJPA-887
> URL: https://issues.apache.org/jira/browse/OPENJPA-887
> Project: OpenJPA
> Issue Type: Bug
> Affects Versions: 1.3.0, 2.0.0-M1, 2.0.0
> Reporter: Milosz Tylenda
> Assignee: Milosz Tylenda
> Priority: Trivial
> Attachments: OPENJPA-887.patch
>
>
> There is a small but quite nasty oversight in TestLibService class:
> assertNotNull("could not find the reference from " + bName + "'s volunteer status back to " + bName, volunteer.getBorrower() == borrower);
> I suspect the intention was to have assertTrue(...). The above compiles because of autoboxing creating a Boolean but the assertion is always true, even if volunteer.getBorrower() != borrower.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-887) Assertion oversight in
TestLibService
Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694569#action_12694569 ]
Milosz Tylenda commented on OPENJPA-887:
----------------------------------------
Thanks, Mike. I was aware of this "revert property" feature but was not sure whether I should use this.
Actually, only trunk commit was without a message, the 1.3.x commit had a message but it does not matter now.
> Assertion oversight in TestLibService
> -------------------------------------
>
> Key: OPENJPA-887
> URL: https://issues.apache.org/jira/browse/OPENJPA-887
> Project: OpenJPA
> Issue Type: Bug
> Affects Versions: 1.3.0, 2.0.0-M1, 2.0.0
> Reporter: Milosz Tylenda
> Assignee: Milosz Tylenda
> Priority: Trivial
> Fix For: 1.3.0, 2.0.0
>
> Attachments: OPENJPA-887.patch
>
>
> There is a small but quite nasty oversight in TestLibService class:
> assertNotNull("could not find the reference from " + bName + "'s volunteer status back to " + bName, volunteer.getBorrower() == borrower);
> I suspect the intention was to have assertTrue(...). The above compiles because of autoboxing creating a Boolean but the assertion is always true, even if volunteer.getBorrower() != borrower.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OPENJPA-887) Assertion oversight in
TestLibService
Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Milosz Tylenda resolved OPENJPA-887.
------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
1.3.0
The patch applied to trunk and 1.3.x branch.
I am sorry the trunk commit went without message - I made a kind of "do-it-first-time" mistake. The trunk revision is 759470.
> Assertion oversight in TestLibService
> -------------------------------------
>
> Key: OPENJPA-887
> URL: https://issues.apache.org/jira/browse/OPENJPA-887
> Project: OpenJPA
> Issue Type: Bug
> Affects Versions: 1.3.0, 2.0.0-M1, 2.0.0
> Reporter: Milosz Tylenda
> Assignee: Milosz Tylenda
> Priority: Trivial
> Fix For: 1.3.0, 2.0.0
>
> Attachments: OPENJPA-887.patch
>
>
> There is a small but quite nasty oversight in TestLibService class:
> assertNotNull("could not find the reference from " + bName + "'s volunteer status back to " + bName, volunteer.getBorrower() == borrower);
> I suspect the intention was to have assertTrue(...). The above compiles because of autoboxing creating a Boolean but the assertion is always true, even if volunteer.getBorrower() != borrower.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.