You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/05/21 21:56:52 UTC
[GitHub] [geode] rhoughton-pivot opened a new pull request #6510: GEODE-9298: remove concourse deprecation warnings
rhoughton-pivot opened a new pull request #6510:
URL: https://github.com/apache/geode/pull/6510
Merging this PR will wipe Concourse history due to pipeline and/or job
name changes.
Thank you for submitting a contribution to Apache Geode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #6510: GEODE-9298: remove concourse deprecation warnings
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on pull request #6510:
URL: https://github.com/apache/geode/pull/6510#issuecomment-846335873
On second look, the way we have the jobs templated, we can't use any simple Jinja tricks to modify the names and keep the old ones, and the full rename-effort is not worth it for the sake of history. Any artifacts are uploaded to GCS as needed anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #6510: GEODE-9298: remove concourse deprecation warnings
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on pull request #6510:
URL: https://github.com/apache/geode/pull/6510#issuecomment-846283241
Test deployment of the `meta` pipeline here: https://concourse.apachegeode-ci.info/teams/main/pipelines/rhoughton-pivot-feature-concourse-de-meta
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal merged pull request #6510: GEODE-9298: remove concourse deprecation warnings
Posted by GitBox <gi...@apache.org>.
onichols-pivotal merged pull request #6510:
URL: https://github.com/apache/geode/pull/6510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #6510: GEODE-9298: remove concourse deprecation warnings
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on pull request #6510:
URL: https://github.com/apache/geode/pull/6510#issuecomment-848982659
> please also change `_` to `-` in the three benchmarks jobs names for consistency, and update .asf.yaml as well (even though the copy on develop is not yet the source of truth, it will eventually overwrite what's on master when 1.15.0 is released)
Done. Please re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] moleske commented on pull request #6510: GEODE-9298: remove concourse deprecation warnings
Posted by GitBox <gi...@apache.org>.
moleske commented on pull request #6510:
URL: https://github.com/apache/geode/pull/6510#issuecomment-846286183
If you don't want to lose history, there is an `old_name` field available which will allow you keep the history https://concourse-ci.org/jobs.html#schema.job.old_name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] moleske edited a comment on pull request #6510: GEODE-9298: remove concourse deprecation warnings
Posted by GitBox <gi...@apache.org>.
moleske edited a comment on pull request #6510:
URL: https://github.com/apache/geode/pull/6510#issuecomment-846286183
If you don't want to lose history, there is an `old_name` field available which will allow you keep the history https://concourse-ci.org/jobs.html#schema.job.old_name
I used it on my current teams concourse when fixing deprecation warnings and it worked well for us. It also exists for resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] moleske commented on pull request #6510: GEODE-9298: remove concourse deprecation warnings
Posted by GitBox <gi...@apache.org>.
moleske commented on pull request #6510:
URL: https://github.com/apache/geode/pull/6510#issuecomment-846297993
@rhoughton-pivot also forgot to mention that fly has a command for rename pipeline https://concourse-ci.org/managing-pipelines.html#fly-rename-pipeline to preserve pipeline history if changing the pipeline name. Might be harder to do with automation, but it also should be a one time thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #6510: GEODE-9298: remove concourse deprecation warnings
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on pull request #6510:
URL: https://github.com/apache/geode/pull/6510#issuecomment-846296182
> If you don't want to lose history, there is an `old_name` field available which will allow you keep the history https://concourse-ci.org/jobs.html#schema.job.old_name
>
> I used it on my current teams concourse when fixing deprecation warnings and it worked well for us. It also exists for resources
I should add that to keep folk happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org