You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/08 06:16:42 UTC
[GitHub] [spark] itholic opened a new pull request, #38554: [SPARK-41042][SQL] Rename `PARSE_CHAR_MISSING_LENGTH` to `DATA_TYPE_MISSING_SIZE`
itholic opened a new pull request, #38554:
URL: https://github.com/apache/spark/pull/38554
### What changes were proposed in this pull request?
This PR proposes to rename `PARSE_CHAR_MISSING_LENGTH` to `DATA_TYPE_MISSING_SIZE`
### Why are the changes needed?
The error class name is specific to `CHAR`, but we get <type> as a parameter in this error class.
The error class should cover more general and have clear name, such as the future types beyond `CHAR`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
```
./build/sbt “sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*”
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38554: [SPARK-41042][SQL] Rename `PARSE_CHAR_MISSING_LENGTH` to `DATATYPE_MISSING_SIZE`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38554: [SPARK-41042][SQL] Rename `PARSE_CHAR_MISSING_LENGTH` to `DATATYPE_MISSING_SIZE`
URL: https://github.com/apache/spark/pull/38554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38554: [SPARK-41042][SQL] Rename `PARSE_CHAR_MISSING_LENGTH` to `DATATYPE_MISSING_SIZE`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38554:
URL: https://github.com/apache/spark/pull/38554#issuecomment-1307352209
+1, LGTM. Merging to master.
Thank you, @itholic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org