You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "cambyzju (via GitHub)" <gi...@apache.org> on 2023/02/07 15:59:08 UTC

[GitHub] [doris] cambyzju commented on a diff in pull request #16480: [fix](partition cache) fix can not hit partition cache

cambyzju commented on code in PR #16480:
URL: https://github.com/apache/doris/pull/16480#discussion_r1098859796


##########
fe/fe-core/src/main/java/org/apache/doris/qe/cache/CacheAnalyzer.java:
##########
@@ -208,12 +208,6 @@ private CacheMode innerCheckCacheMode(long now) {
                 LOG.debug("query contains non-olap table. queryid {}", DebugUtil.printId(queryId));
                 return CacheMode.None;
             }
-            if (enablePartitionCache() && ((OlapScanNode) node).getSelectedPartitionNum() > 1

Review Comment:
   we should better figure out why we add these codes before, the codes added from https://github.com/apache/doris/pull/10319



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org