You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/07/28 01:28:25 UTC

[GitHub] [libcloud] tonynguien commented on a change in pull request #1596: EC2: Add support for gp3 and io2 volumes

tonynguien commented on a change in pull request #1596:
URL: https://github.com/apache/libcloud/pull/1596#discussion_r677907050



##########
File path: libcloud/compute/drivers/ec2.py
##########
@@ -2157,6 +2163,9 @@ def create_volume(self, size, name, location=None, snapshot=None,
             if ex_kms_key_id is not None:
                 params['KmsKeyId'] = ex_kms_key_id
 
+        if ex_volume_type == 'gp3' and ex_throughput:

Review comment:
       I believe we want to allow caller to specify throughput for io1 and io2 volume types, similar to iops.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org