You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2011/09/15 13:28:08 UTC
[jira] [Created] (AMQ-3500) Setting destination options should
validate against typos
Setting destination options should validate against typos
---------------------------------------------------------
Key: AMQ-3500
URL: https://issues.apache.org/jira/browse/AMQ-3500
Project: ActiveMQ
Issue Type: Improvement
Reporter: Claus Ibsen
Assignee: Claus Ibsen
Priority: Minor
I think the logic does not validate that all the destination option was succesfully configured.
http://activemq.apache.org/destination-options.html
So if you make a typo, AMQ may continue as normal.
We should add logic like in Camel, where we check the Map is zero after the introspection logic have set the options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-3500) Setting destination options should
validate against typos
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated AMQ-3500:
-----------------------------
Attachment: AMQ-3500.patch
> Setting destination options should validate against typos
> ---------------------------------------------------------
>
> Key: AMQ-3500
> URL: https://issues.apache.org/jira/browse/AMQ-3500
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Attachments: AMQ-3500.patch
>
>
> I think the logic does not validate that all the destination option was succesfully configured.
> http://activemq.apache.org/destination-options.html
> So if you make a typo, AMQ may continue as normal.
> We should add logic like in Camel, where we check the Map is zero after the introspection logic have set the options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3500) Setting destination options should
validate against typos
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113469#comment-13113469 ]
Timothy Bish commented on AMQ-3500:
-----------------------------------
Just remember that ActiveMQProducer has similar code to apply options so it may make sense to add this same logic there as well.
> Setting destination options should validate against typos
> ---------------------------------------------------------
>
> Key: AMQ-3500
> URL: https://issues.apache.org/jira/browse/AMQ-3500
> Project: ActiveMQ
> Issue Type: Improvement
> Affects Versions: 5.5.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3500.patch
>
>
> I think the logic does not validate that all the destination option was succesfully configured.
> http://activemq.apache.org/destination-options.html
> So if you make a typo, AMQ may continue as normal.
> We should add logic like in Camel, where we check the Map is zero after the introspection logic have set the options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3500) Setting destination options should
validate against typos
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105552#comment-13105552 ]
Claus Ibsen commented on AMQ-3500:
----------------------------------
Attached is a patch that logs a WARN and throws a ConfigurationException if any of the Destination Options is invalid
{code}
WARN ActiveMQMessageConsumer - There are 1 consumer options that couldn't be set on the consumer. Check the options are spelt correctly. Unknown parameters=[{consumer.unknown=foo}]. This consumer cannot be started.
{code}
> Setting destination options should validate against typos
> ---------------------------------------------------------
>
> Key: AMQ-3500
> URL: https://issues.apache.org/jira/browse/AMQ-3500
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Attachments: AMQ-3500.patch
>
>
> I think the logic does not validate that all the destination option was succesfully configured.
> http://activemq.apache.org/destination-options.html
> So if you make a typo, AMQ may continue as normal.
> We should add logic like in Camel, where we check the Map is zero after the introspection logic have set the options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3500) Setting destination options should
validate against typos
Posted by "Timothy Bish (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128410#comment-13128410 ]
Timothy Bish commented on AMQ-3500:
-----------------------------------
After letting the tests run I realized this fix was a bit to aggressive, it should only check that all the params inside the domain of producer or consumer are applied. Its not uncommon for a single destination with producer and consumer options to be used to create both.
> Setting destination options should validate against typos
> ---------------------------------------------------------
>
> Key: AMQ-3500
> URL: https://issues.apache.org/jira/browse/AMQ-3500
> Project: ActiveMQ
> Issue Type: Improvement
> Affects Versions: 5.5.0
> Reporter: Claus Ibsen
> Assignee: Timothy Bish
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3500.patch
>
>
> I think the logic does not validate that all the destination option was succesfully configured.
> http://activemq.apache.org/destination-options.html
> So if you make a typo, AMQ may continue as normal.
> We should add logic like in Camel, where we check the Map is zero after the introspection logic have set the options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-3500) Setting destination options should
validate against typos
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated AMQ-3500:
-----------------------------
Affects Version/s: 5.5.0
Fix Version/s: 5.6.0
> Setting destination options should validate against typos
> ---------------------------------------------------------
>
> Key: AMQ-3500
> URL: https://issues.apache.org/jira/browse/AMQ-3500
> Project: ActiveMQ
> Issue Type: Improvement
> Affects Versions: 5.5.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3500.patch
>
>
> I think the logic does not validate that all the destination option was succesfully configured.
> http://activemq.apache.org/destination-options.html
> So if you make a typo, AMQ may continue as normal.
> We should add logic like in Camel, where we check the Map is zero after the introspection logic have set the options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AMQ-3500) Setting destination options should
validate against typos
Posted by "Timothy Bish (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish resolved AMQ-3500.
-------------------------------
Resolution: Fixed
Applied the patch, also made a similar change to the MessageProducer to check the options are all applied.
> Setting destination options should validate against typos
> ---------------------------------------------------------
>
> Key: AMQ-3500
> URL: https://issues.apache.org/jira/browse/AMQ-3500
> Project: ActiveMQ
> Issue Type: Improvement
> Affects Versions: 5.5.0
> Reporter: Claus Ibsen
> Assignee: Timothy Bish
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3500.patch
>
>
> I think the logic does not validate that all the destination option was succesfully configured.
> http://activemq.apache.org/destination-options.html
> So if you make a typo, AMQ may continue as normal.
> We should add logic like in Camel, where we check the Map is zero after the introspection logic have set the options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (AMQ-3500) Setting destination options should
validate against typos
Posted by "Timothy Bish (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish reassigned AMQ-3500:
---------------------------------
Assignee: Timothy Bish (was: Claus Ibsen)
> Setting destination options should validate against typos
> ---------------------------------------------------------
>
> Key: AMQ-3500
> URL: https://issues.apache.org/jira/browse/AMQ-3500
> Project: ActiveMQ
> Issue Type: Improvement
> Affects Versions: 5.5.0
> Reporter: Claus Ibsen
> Assignee: Timothy Bish
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3500.patch
>
>
> I think the logic does not validate that all the destination option was succesfully configured.
> http://activemq.apache.org/destination-options.html
> So if you make a typo, AMQ may continue as normal.
> We should add logic like in Camel, where we check the Map is zero after the introspection logic have set the options.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-3500) Setting destination options should
validate against typos
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113455#comment-13113455 ]
Timothy Bish commented on AMQ-3500:
-----------------------------------
Looks good. The patch doesn't apply cleanly though with the test case renamed.
> Setting destination options should validate against typos
> ---------------------------------------------------------
>
> Key: AMQ-3500
> URL: https://issues.apache.org/jira/browse/AMQ-3500
> Project: ActiveMQ
> Issue Type: Improvement
> Affects Versions: 5.5.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3500.patch
>
>
> I think the logic does not validate that all the destination option was succesfully configured.
> http://activemq.apache.org/destination-options.html
> So if you make a typo, AMQ may continue as normal.
> We should add logic like in Camel, where we check the Map is zero after the introspection logic have set the options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-3500) Setting destination options should
validate against typos
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated AMQ-3500:
-----------------------------
Patch Info: [Patch Available]
> Setting destination options should validate against typos
> ---------------------------------------------------------
>
> Key: AMQ-3500
> URL: https://issues.apache.org/jira/browse/AMQ-3500
> Project: ActiveMQ
> Issue Type: Improvement
> Affects Versions: 5.5.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 5.6.0
>
> Attachments: AMQ-3500.patch
>
>
> I think the logic does not validate that all the destination option was succesfully configured.
> http://activemq.apache.org/destination-options.html
> So if you make a typo, AMQ may continue as normal.
> We should add logic like in Camel, where we check the Map is zero after the introspection logic have set the options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira