You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/08/26 10:49:52 UTC
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #4416: License: add Bluetooth LE support to the license guard
jerpelea opened a new pull request #4416:
URL: https://github.com/apache/incubator-nuttx/pull/4416
## Summary
If ALLOW_BSD_COMPONENTS is not enabled in the license setup,
Bluetooth LE support will be disabled
## Impact
LICENSE
## Testing
BUILD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #4416: License: add Bluetooth LE support to the license guard
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #4416:
URL: https://github.com/apache/incubator-nuttx/pull/4416#issuecomment-906331972
>
>
> Need enable CONFIG_ALLOW_BSD_COMPONENTS:
> modified: boards/sim/sim/sim/configs/bluetooth/defconfig
> modified: boards/sim/sim/sim/configs/bthcisock/defconfig
> modified: boards/sim/sim/sim/configs/btuart/defconfig
> modified: boards/sim/sim/sim/configs/nimble/defconfig
in my understanding by default the BSD components should be disabled and not included in any defconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4416: License: add Bluetooth LE support to the license guard
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4416:
URL: https://github.com/apache/incubator-nuttx/pull/4416#issuecomment-906327660
Need enable CONFIG_ALLOW_BSD_COMPONENTS:
modified: boards/sim/sim/sim/configs/bluetooth/defconfig
modified: boards/sim/sim/sim/configs/bthcisock/defconfig
modified: boards/sim/sim/sim/configs/btuart/defconfig
modified: boards/sim/sim/sim/configs/nimble/defconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #4416: License: add Bluetooth LE support to the license guard
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #4416:
URL: https://github.com/apache/incubator-nuttx/pull/4416#issuecomment-906326464
>
>
> It would be nice if Kconfig could support some features like this: you set BLE to select the BSD license, but before that, the user will be asked if they agree.
> Using "depends on" will hide the feature and people will not know it is supported on NuttX. Other option (because it is BSD license) we can change it to Apache. Same way Samsung did with NuttX when they created TizenRT using Apache license.
I agree with the suggestion and we will probably implement it for the nuttx-extra git but for the NuttX 11 release we should just use "depends on" and add the files affected by the license for each component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4416: License: add Bluetooth LE support to the license guard
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4416:
URL: https://github.com/apache/incubator-nuttx/pull/4416#issuecomment-906332594
if so, all these config could be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4416: License: add Bluetooth LE support to the license guard
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4416:
URL: https://github.com/apache/incubator-nuttx/pull/4416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #4416: License: add Bluetooth LE support to the license guard
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #4416:
URL: https://github.com/apache/incubator-nuttx/pull/4416#issuecomment-906331972
>
>
> Need enable CONFIG_ALLOW_BSD_COMPONENTS:
> modified: boards/sim/sim/sim/configs/bluetooth/defconfig
> modified: boards/sim/sim/sim/configs/bthcisock/defconfig
> modified: boards/sim/sim/sim/configs/btuart/defconfig
> modified: boards/sim/sim/sim/configs/nimble/defconfig
in my understanding by default the BSD components should be disabled and not included in any defconfig. Since those configs are Simulator configs this should be an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #4416: License: add Bluetooth LE support to the license guard
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4416:
URL: https://github.com/apache/incubator-nuttx/pull/4416#issuecomment-906323955
It would be nice if Kconfig could support some features like this: you set BLE to select the BSD license, but before that, the user will be asked if they agree.
Using "depends on" will hide the feature and people will not know it is supported on NuttX. Other option (because it is BSD license) we can change it to Apache. Same way Samsung did with NuttX when they created TizenRT using Apache license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #4416: License: add Bluetooth LE support to the license guard
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #4416:
URL: https://github.com/apache/incubator-nuttx/pull/4416#issuecomment-906332941
>
>
> if so, all these config could be removed
Since those configs are Simulator configs this should be an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org