You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by troyding <gi...@git.apache.org> on 2014/05/19 09:01:18 UTC
[GitHub] incubator-storm pull request: [STORM-326] Task metric send repeate...
GitHub user troyding opened a pull request:
https://github.com/apache/incubator-storm/pull/118
[STORM-326] Task metric send repeatedly
This pull request addresses storm issue [STORM-326](https://issues.apache.org/jira/browse/STORM-326).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/troyding/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/118.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #118
----
commit d20ba2e720f66529c1b187d855c857ee6f8d78f2
Author: troyding <di...@gmail.com>
Date: 2014-05-19T06:18:34Z
bug fix: task metric send repeatedly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-326] Task metric send repeate...
Posted by troyding <gi...@git.apache.org>.
Github user troyding commented on the pull request:
https://github.com/apache/incubator-storm/pull/118#issuecomment-43731861
hi @revans2 and @ptgoetz, I have added a unit test function "test-custom-metric-with-multi-tasks" into the `metrics_test.clj` file. This test case will help to reproduce the error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-326] Task metric send repeate...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/118#issuecomment-43555788
The change looks good to me I am +1, but it would be nice to see a test case that reproduces the error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-326] Task metric send repeate...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/118#issuecomment-44443296
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-326] Task metric send repeate...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/118#issuecomment-43626596
I was thinking more along the lines of a unit test, but a manual test is OK too. I would prefer to not merge it into the final release though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-326] Task metric send repeate...
Posted by troyding <gi...@git.apache.org>.
Github user troyding commented on the pull request:
https://github.com/apache/incubator-storm/pull/118#issuecomment-43584255
Thank you for your advice @revans2 . I have added a new class named ExclamationTopologyWithMetrics to reproduce the error. The newly added class is based on the existed ExclamationTopology class. For testing, I set the parallelism of the bolt named "exclaim1" to 3, and its task number to 6, and the parallelism and task number of the second bolt named "exclaim2" to 2 and 6, respectively. After running the topology, I got the following results:
As shown in the Figure, the task "4:exclaim1" has repeated twice of the metric reporting, and the task "11:exclaim2" has repeated three times, as we expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-326] Task metric send repeate...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/118#issuecomment-43672419
@troyding I tend to agree with @revans2. Can you add a clojure unit test for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-326] Task metric send repeate...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-326] Task metric send repeate...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/118#issuecomment-43782502
+1 the test passes with the change, and fails without it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-326] Task metric send repeate...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/118#issuecomment-43785144
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---