[jira] [Commented] (CXF-4164) Robust-InOnly processing with WS-RM must must delay updating the sequence until message delivery

["Dennis Sosnoski (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222809#comment-13222809 ] 

Dennis Sosnoski commented on CXF-4164:
--------------------------------------

This is probably the way all WS-RM processing should work, so that messages are only acknowledged once they've been delivered to the application and processed. The current code appears to allow a timing window where a crash would mean the message has been accepted and acknowledged by RM processing but is never seen by the application.

It looks like all that needs to be done for 2.5.x+ is to remove the call to destination.acknowledge() from RMInInterceptor.processSequence() and instead call it from RMDeliveryInterceptor.handle() (before the call to processingComplete()).

                
> Robust-InOnly processing with WS-RM must must delay updating the sequence until message delivery
> ------------------------------------------------------------------------------------------------
>
>                 Key: CXF-4164
>                 URL: https://issues.apache.org/jira/browse/CXF-4164
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.4.7, 2.5.3
>            Reporter: Aki Yoshida
>            Assignee: Aki Yoshida
>             Fix For: 2.4.7, 2.5.3, 2.6
>
>
> A recently added robust-inonly mode (CXF-4096) can be used to invoke services synchronously so that the caller can distinguish a successful invocation from an unsuccessful one. 
> Although this feature is implemented independently of WS-RM, it can be used with WS-RM to force the acknowledgement message to be returned only after the service invocation successfully completes. 
> Unfortunately, there is a minor change required in WS-RM so that this feature will work for this use case. Namely, it must be made aware of this robust setting so that it can postpone updating the sequence until the message is delivered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira