You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by seancxmao <gi...@git.apache.org> on 2018/08/29 06:45:28 UTC

[GitHub] spark pull request #22262: [SPARK-25175][SQL] Field resolution should fail i...

GitHub user seancxmao opened a pull request:

    https://github.com/apache/spark/pull/22262

    [SPARK-25175][SQL] Field resolution should fail if there is ambiguity for ORC native reader

    ## What changes were proposed in this pull request?
    This PR aims to make ORC data source native implementation consistent with Parquet data source. The gap is that field resolution should fail if there is ambiguity in case-insensitive mode when reading from ORC.
    
    See #22148 for more details about parquet data source reader.
    
    ## How was this patch tested?
    Unit tests added.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/seancxmao/spark SPARK-25175

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22262
    
----
commit 366bb35ad62edb8e6707e65c681a5b9001cc868e
Author: seancxmao <se...@...>
Date:   2018-08-17T10:06:28Z

    [SPARK-25175][SQL] Field resolution should fail if there's ambiguity for ORC native reader

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by seancxmao <gi...@git.apache.org>.
Github user seancxmao commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    @dongjoon-hyun That's all right :). I have reverted to the first commit and adjusted the indentation.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95792/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    **[Test build #95827 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95827/testReport)** for PR 22262 at commit [`26b4710`](https://github.com/apache/spark/commit/26b4710bb47e700d3532da5652fd5ea3f128be20).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    ok to test


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Thank you, @seancxmao .


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    **[Test build #95824 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95824/testReport)** for PR 22262 at commit [`366bb35`](https://github.com/apache/spark/commit/366bb35ad62edb8e6707e65c681a5b9001cc868e).
     * This patch **fails due to an unknown error code, -9**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    BTW, I think we need this duplication check in case-sensitive mode, too. I'll ping on previous Parquet PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Thank you, @seancxmao .
    Also, I made a PR to you, https://github.com/seancxmao/spark/pull/1 , to simply the logic.
    Could you review and merge that if you think that's okay?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Sorry, but I'm still feeling that this PR is losing focus. How about mentioning what you do in this PR like the following?
    
    ```
    Apache Spark doesn't create Hive table with duplicated fields in both case-sensitive and
    case-insensitive mode. However, if Spark creates ORC files in case-sensitive mode first
    and create Hive table on that location, it's created. In this situation, field resolution should
    fail in case-insensitive mode. Otherwise, we don't know which columns will be returned or
    filtered. Previously, SPARK-25132 fixed the same issue in Parquet.
    
    Here is a simple example:
    ...
    ```



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by seancxmao <gi...@git.apache.org>.
Github user seancxmao commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    I updated the PR description.  Thank you for pointing that PR description should stay focused. I also think it's more clear.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95827/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    **[Test build #95825 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95825/testReport)** for PR 22262 at commit [`26b4710`](https://github.com/apache/spark/commit/26b4710bb47e700d3532da5652fd5ea3f128be20).
     * This patch **fails due to an unknown error code, -9**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by seancxmao <gi...@git.apache.org>.
Github user seancxmao commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    > ... we need this duplication check in case-sensitive mode ...
    Do you mean we may define ORC/Parquet schema with identical field names (even in the same letter case)? Would you please explain a bit more on this?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    @seancxmao . I mistook yesterday. Could you restore to your first commit? In the first commit, please adjust the indentation at [line 140](https://github.com/apache/spark/pull/22262/commits/366bb35ad62edb8e6707e65c681a5b9001cc868e#diff-3fb8426b690ab771c4f67f9cad336498R140). Sorry for the back and forth! 
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Thank you, @seancxmao . I'll review tonight again.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    **[Test build #95792 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95792/testReport)** for PR 22262 at commit [`fa2a45f`](https://github.com/apache/spark/commit/fa2a45f5bff1b9ff15d977af46a071e09ec3267d).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    **[Test build #95827 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95827/testReport)** for PR 22262 at commit [`26b4710`](https://github.com/apache/spark/commit/26b4710bb47e700d3532da5652fd5ea3f128be20).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    **[Test build #95824 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95824/testReport)** for PR 22262 at commit [`366bb35`](https://github.com/apache/spark/commit/366bb35ad62edb8e6707e65c681a5b9001cc868e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #22262: [SPARK-25175][SQL] Field resolution should fail i...

Posted by seancxmao <gi...@git.apache.org>.
Github user seancxmao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22262#discussion_r216121510
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala ---
    @@ -116,6 +116,14 @@ object OrcUtils extends Logging {
             })
           } else {
             val resolver = if (isCaseSensitive) caseSensitiveResolution else caseInsensitiveResolution
    +        // Need to fail if there is ambiguity, i.e. more than one field is matched.
    +        requiredSchema.fieldNames.foreach { requiredFieldName =>
    +          val matchedOrcFields = orcFieldNames.filter(resolver(_, requiredFieldName))
    --- End diff --
    
    That's all right :)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #22262: [SPARK-25175][SQL] Field resolution should fail i...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22262#discussion_r216119226
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala ---
    @@ -116,6 +116,14 @@ object OrcUtils extends Logging {
             })
           } else {
             val resolver = if (isCaseSensitive) caseSensitiveResolution else caseInsensitiveResolution
    +        // Need to fail if there is ambiguity, i.e. more than one field is matched.
    +        requiredSchema.fieldNames.foreach { requiredFieldName =>
    +          val matchedOrcFields = orcFieldNames.filter(resolver(_, requiredFieldName))
    --- End diff --
    
    Sorry, @seancxmao . We need to update once more. I'll make a PR to you.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Merged to master/2.4.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #22262: [SPARK-25175][SQL] Field resolution should fail i...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/22262


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    @seancxmao . Could you explain why we need this PR? Apache Spark 2.3.1 already shows exceptions like the following for the case (for both ORC and Parquet), doesn't it?
    
    ```scala
    scala> spark.version
    res5: String = 2.3.1
    
    scala> sql("set spark.sql.caseSensitive=true")
    scala> spark.read.orc("/tmp/o").printSchema
    root
     |-- a: integer (nullable = true)
     |-- A: integer (nullable = true)
    
    scala> sql("set spark.sql.caseSensitive=false")
    scala> spark.read.orc("/tmp/o").printSchema
    18/09/01 20:06:05 WARN DataSource: Found duplicate column(s) in the data schema and the partition schema: `a`;
    org.apache.spark.sql.AnalysisException: Found duplicate column(s) in the data schema: `a`;
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by seancxmao <gi...@git.apache.org>.
Github user seancxmao commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    @dongjoon-hyun Thank you!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    The following is the sequence.
    
    ```scala
    scala> sql("insert overwrite local directory '/tmp/parquet' stored as parquet select 1 id, 2 id")
    ```
    
    ```
    $ parquet-tools schema /tmp/parquet
    message hive_schema {
      optional int32 id;
      optional int32 id;
    }
    ```
    
    ```scala
    scala> sql("create table parquet(id int) USING parquet LOCATION '/tmp/parquet'")
    res3: org.apache.spark.sql.DataFrame = []
    
    scala> sql("select * from parquet")
    res4: org.apache.spark.sql.DataFrame = [id: int]
    
    scala> sql("select * from parquet").show
    18/09/07 23:31:03 ERROR Executor: Exception in task 0.0 in stage 2.0 (TID 2)
    java.lang.RuntimeException: [id] INT32 was added twice
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    **[Test build #95792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95792/testReport)** for PR 22262 at commit [`fa2a45f`](https://github.com/apache/spark/commit/fa2a45f5bff1b9ff15d977af46a071e09ec3267d).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Retest this please.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95825/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by seancxmao <gi...@git.apache.org>.
Github user seancxmao commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    @dongjoon-hyun @cloud-fan @gatorsmile Could you please kindly review this?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95824/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by seancxmao <gi...@git.apache.org>.
Github user seancxmao commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    @dongjoon-hyun I have updated PR description to explain in more details. As you mentioned, this PR is specific to the case when reading from data source table persisted in metastore.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #22262: [SPARK-25175][SQL] Field resolution should fail if there...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22262
  
    **[Test build #95825 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95825/testReport)** for PR 22262 at commit [`26b4710`](https://github.com/apache/spark/commit/26b4710bb47e700d3532da5652fd5ea3f128be20).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org