You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2018/07/10 07:33:04 UTC
[GitHub] carbondata pull request #2467: [CARBONDATA-2649] Add code for caching min/ma...
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2467#discussion_r201242748
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentPropertiesAndSchemaHolder.java ---
@@ -289,20 +293,24 @@ public SegmentProperties getSegmentProperties() {
return columnCardinality;
}
- public CarbonRowSchema[] getBlockSchema() {
- return SchemaGenerator.createBlockSchema(segmentProperties);
+ public synchronized CarbonRowSchema[] getTaskSummarySchema() {
+ return taskSummarySchema;
}
- public CarbonRowSchema[] getBlocketSchema() {
- return SchemaGenerator.createBlockletSchema(segmentProperties);
+ public synchronized void setTaskSummarySchema(CarbonRowSchema[] taskSummarySchema) {
--- End diff --
I think synchronized is no required here , please check
---