[GitHub] [uima-uimaj] mjunsilo edited a comment on pull request #66: [UIMA 6273] isBeforeV3 variable not reset in BinaryCasSerDes

[GitBox <gi...@apache.org>]

mjunsilo edited a comment on pull request #66:
URL: https://github.com/apache/uima-uimaj/pull/66#issuecomment-708357086


   I am still thinking about how a unit test could be done, but I am short on time at the moment. A proper integrated test requires a solution where a v2 binary is loaded from test resources followed by a CAS reset, load of CAS v3 and final verification of the CAS. Problem is that I have to reproduce the error first with a small enough example before applying the fix, so there can be a fair amount of work to get to that point. The slightly simpler version would be just to check that the isBeforeV3 variable is probably set before and after v3 load, v2 load and reset instead of verifying the whole contents. I also had a quick look at the existing tests like "org.apache.uima.cas.impl.SerDesTest6", but I need to spend more time understanding how they work, before I could say that I could reuse some of that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org