You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@streampipes.apache.org by Philipp Zehnder <ph...@bytefabrik.ai> on 2022/12/22 15:26:17 UTC

[DISCUSS] Add git pre-commit hook for checkstyle

Hi all,

we are almost done with enabling checkstyle for all Java modules.
I would suggest that we also add a git pre-commit hook to check that the code is formatted appropriately, as we have now for Ttypescript (see [2]).

I have created an issue for this [3]. If anyone has experience with this, I appreciate any help or tips.


Should we also integrate this validation into GitHub actions?

I am not sure if we need an additional step for it, since the PR validation already runs a ‘mvn clean verify‘.

Cheers,
Philipp

[1] https://github.com/apache/streampipes/issues/820
[2] https://github.com/apache/streampipes/pull/876
[3] https://github.com/apache/streampipes/issues/880