You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/08 09:28:01 UTC

[GitHub] [apisix-dashboard] Jaycean opened a new issue #1461: feat: Confirm whether the store related functions are still in use. If not, delete them

Jaycean opened a new issue #1461:
URL: https://github.com/apache/apisix-dashboard/issues/1461


   # Feature request
   
   ## Please describe your feature
   
   comment: https://github.com/apache/apisix-dashboard/pull/1452#discussion_r571882686
   Confirm whether the store related functions are still in use. If not, delete them.
   ```
   store.NewFilter([]string{"name", name})
   store.NewPagination(0, 0)
   store.NewQuery(sort, filter, pagination)
   store.NewFilterSelector(toRows(ret), query)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan closed issue #1461: feat: Confirm whether the store related functions are still in use. If not, delete them

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1461:
URL: https://github.com/apache/apisix-dashboard/issues/1461


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz commented on issue #1461: feat: Confirm whether the store related functions are still in use. If not, delete them

Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1461:
URL: https://github.com/apache/apisix-dashboard/issues/1461#issuecomment-775607779


   We can remove it and refactor the logic using it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] Jaycean commented on issue #1461: feat: Confirm whether the store related functions are still in use. If not, delete them

Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1461:
URL: https://github.com/apache/apisix-dashboard/issues/1461#issuecomment-794753390


   > > I see pr: #1568 issue: #1567
   > > Think of this issue.
   > 
   > Oh Yes.Sorry for forgetting this.
   
   It doesn't matter. Actually, I forgot it. It's my problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] starsz commented on issue #1461: feat: Confirm whether the store related functions are still in use. If not, delete them

Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1461:
URL: https://github.com/apache/apisix-dashboard/issues/1461#issuecomment-794752457


   > I see pr: #1568 issue: #1567
   > Think of this issue.
   
   Oh Yes.Sorry for forgetting this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] Jaycean commented on issue #1461: feat: Confirm whether the store related functions are still in use. If not, delete them

Posted by GitBox <gi...@apache.org>.
Jaycean commented on issue #1461:
URL: https://github.com/apache/apisix-dashboard/issues/1461#issuecomment-794158337


   I see pr: #1568  issue: #1567 
   Think of this issue.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org