[GitHub] [pulsar] hangc0276 commented on a change in pull request #12366: expose broker bundles metrics to prometheus

[GitBox <gi...@apache.org>]

hangc0276 commented on a change in pull request #12366:
URL: https://github.com/apache/pulsar/pull/12366#discussion_r742465671



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
##########
@@ -916,6 +916,7 @@ public LocalBrokerData updateLocalBrokerData() {
             final SystemResourceUsage systemResourceUsage = LoadManagerShared.getSystemResourceUsage(brokerHostUsage);
             localData.update(systemResourceUsage, getBundleStats());
             updateLoadBalancingMetrics(systemResourceUsage);
+            updateLoadBalancingBundlesMetrics(getBundleStats());

Review comment:
       We'd better add a flag to control whether to expose bundle stats, because the bundle metrics will introduce a lot of metrics, which will increase the load of metric system.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org