You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Shilamkar <gi...@clogeny.com> on 2013/09/25 15:34:22 UTC
Review Request 14335: CLOUDSTACK-4262: Fix
TestVPCNetworkGc.test_01_wait_network_gc
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14335/
-----------------------------------------------------------
Review request for cloudstack, Harikrishna Patnala and venkata swamy babu budumuru.
Bugs: CLOUDSTACK-4262
Repository: cloudstack-git
Description
-------
As per the test plan, after waiting for network gc
LB rules should be cleared. Added that check instead of router
being in stopped state.
Diffs
-----
test/integration/component/test_vpc_network.py 970a625
Diff: https://reviews.apache.org/r/14335/diff/
Testing
-------
Thanks,
Girish Shilamkar
Re: Review Request 14335: CLOUDSTACK-4262: Fix
TestVPCNetworkGc.test_01_wait_network_gc
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14335/#review26924
-----------------------------------------------------------
Commit 808b96070e17976f8ae7424b437713f329be7ac4 in branch refs/heads/4.2 from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=808b960 ]
CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc
As per the test plan, after waiting for network gc
LB rules should be cleared. Added that check instead of router
being in stopped state.
Signed-off-by: venkataswamybabu budumuru <ve...@citrix.com>
(cherry picked from commit abdb84bb05abc9f2bd102bca1c1b34865f34d771)
- ASF Subversion and Git Services
On Oct. 7, 2013, 4:54 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14335/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 4:54 a.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala and venkata swamy babu budumuru.
>
>
> Bugs: CLOUDSTACK-4262
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As per the test plan, after waiting for network gc
> LB rules should be cleared. Added that check instead of router
> being in stopped state.
>
>
> Diffs
> -----
>
> test/integration/component/test_vpc_network.py 970a625
>
> Diff: https://reviews.apache.org/r/14335/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 14335: CLOUDSTACK-4262: Fix
TestVPCNetworkGc.test_01_wait_network_gc
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14335/#review26732
-----------------------------------------------------------
Commit abdb84bb05abc9f2bd102bca1c1b34865f34d771 in branch refs/heads/4.2-forward from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=abdb84b ]
CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc
As per the test plan, after waiting for network gc
LB rules should be cleared. Added that check instead of router
being in stopped state.
Signed-off-by: venkataswamybabu budumuru <ve...@citrix.com>
- ASF Subversion and Git Services
On Oct. 7, 2013, 4:54 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14335/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 4:54 a.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala and venkata swamy babu budumuru.
>
>
> Bugs: CLOUDSTACK-4262
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As per the test plan, after waiting for network gc
> LB rules should be cleared. Added that check instead of router
> being in stopped state.
>
>
> Diffs
> -----
>
> test/integration/component/test_vpc_network.py 970a625
>
> Diff: https://reviews.apache.org/r/14335/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 14335: CLOUDSTACK-4262: Fix
TestVPCNetworkGc.test_01_wait_network_gc
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14335/#review26725
-----------------------------------------------------------
Ship it!
Patch is good to commit. Some commiter has to push it to master.
- sanjeev n
On Oct. 7, 2013, 4:54 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14335/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 4:54 a.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala and venkata swamy babu budumuru.
>
>
> Bugs: CLOUDSTACK-4262
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As per the test plan, after waiting for network gc
> LB rules should be cleared. Added that check instead of router
> being in stopped state.
>
>
> Diffs
> -----
>
> test/integration/component/test_vpc_network.py 970a625
>
> Diff: https://reviews.apache.org/r/14335/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 14335: CLOUDSTACK-4262: Fix
TestVPCNetworkGc.test_01_wait_network_gc
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14335/#review26733
-----------------------------------------------------------
Commit fbf057a3236dcce96c0f08b419963831e411c243 in branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fbf057a ]
CLOUDSTACK-4262: Fix TestVPCNetworkGc.test_01_wait_network_gc
As per the test plan, after waiting for network gc
LB rules should be cleared. Added that check instead of router
being in stopped state.
Signed-off-by: venkataswamybabu budumuru <ve...@citrix.com>
(cherry picked from commit abdb84bb05abc9f2bd102bca1c1b34865f34d771)
- ASF Subversion and Git Services
On Oct. 7, 2013, 4:54 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14335/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 4:54 a.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala and venkata swamy babu budumuru.
>
>
> Bugs: CLOUDSTACK-4262
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As per the test plan, after waiting for network gc
> LB rules should be cleared. Added that check instead of router
> being in stopped state.
>
>
> Diffs
> -----
>
> test/integration/component/test_vpc_network.py 970a625
>
> Diff: https://reviews.apache.org/r/14335/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 14335: CLOUDSTACK-4262: Fix
TestVPCNetworkGc.test_01_wait_network_gc
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14335/
-----------------------------------------------------------
(Updated Oct. 7, 2013, 4:54 a.m.)
Review request for cloudstack, Harikrishna Patnala and venkata swamy babu budumuru.
Changes
-------
I have added the assert for netacls. But it seems the netacls are not cleared. I will file a separate defect for this. Thanks.
Bugs: CLOUDSTACK-4262
Repository: cloudstack-git
Description
-------
As per the test plan, after waiting for network gc
LB rules should be cleared. Added that check instead of router
being in stopped state.
Diffs (updated)
-----
test/integration/component/test_vpc_network.py 970a625
Diff: https://reviews.apache.org/r/14335/diff/
Testing
-------
Thanks,
Girish Shilamkar
Re: Review Request 14335: CLOUDSTACK-4262: Fix
TestVPCNetworkGc.test_01_wait_network_gc
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14335/#review26666
-----------------------------------------------------------
Checking LB rules deletion after network gc looks good to me. However validation is missing in the code after listing NetworkAcl rules after gc.
netacls = NetworkACL.list(self.apiclient, networkid=self.network_1.id)
self.debug("List of NetACLS %s" % netacls)
Add validation whether NetworkACL.list is returning empty or not.
- sanjeev n
On Sept. 25, 2013, 1:34 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14335/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2013, 1:34 p.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala and venkata swamy babu budumuru.
>
>
> Bugs: CLOUDSTACK-4262
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As per the test plan, after waiting for network gc
> LB rules should be cleared. Added that check instead of router
> being in stopped state.
>
>
> Diffs
> -----
>
> test/integration/component/test_vpc_network.py 970a625
>
> Diff: https://reviews.apache.org/r/14335/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Girish Shilamkar
>
>