[GitHub] [tez] abstractdog commented on a diff in pull request #236: TEZ-4441: TezAppMaster may stuck because of reportError skip send err…

[GitBox <gi...@apache.org>]

abstractdog commented on code in PR #236:
URL: https://github.com/apache/tez/pull/236#discussion_r949990203


##########
tez-dag/src/main/java/org/apache/tez/dag/app/rm/TaskSchedulerManager.java:
##########
@@ -910,7 +910,8 @@ public void reportError(int taskSchedulerIndex, ServicePluginError servicePlugin
       LOG.info("Error reported by scheduler {} - {}",
           Utils.getTaskSchedulerIdentifierString(taskSchedulerIndex, appContext) + ": " +
               diagnostics);
-      if (taskSchedulerDescriptors[taskSchedulerIndex].getClassName().equals(yarnSchedulerClassName)) {
+      if (taskSchedulerDescriptors[taskSchedulerIndex].getEntityName()

Review Comment:
   I guess this is the actual fix
   
   just a note, what are the values in your case:
   ```
   taskSchedulerDescriptors[taskSchedulerIndex].getClassName()
   yarnSchedulerClassName
   taskSchedulerDescriptors[taskSchedulerIndex].getEntityName()
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org