You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by mars <gi...@git.apache.org> on 2017/06/16 19:09:27 UTC
[GitHub] incubator-predictionio pull request #394: Extend request timeout for REST AP...
GitHub user mars opened a pull request:
https://github.com/apache/incubator-predictionio/pull/394
Extend request timeout for REST API
We've found the default 20-second REST API request timeout is too short for our batch-prediction use cases. We're running PredictionIO on Heroku which has its own [timeout starting at 30-seonds](https://devcenter.heroku.com/articles/limits#http-timeouts). So we'd prefer a more generous or easily configurable timeout to allow Heroku's routing layer to impose & track this limit in the platform layer.
I investigated how to configure this and found [Spray `application.conf`](http://spray.io/documentation/1.2.4/spray-can/configuration/). This PR simply increases the timeout.
I would love guidance on how we might extract this config into an environment variable or a value in `pio-env.sh`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mars/incubator-predictionio extend-request-timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio/pull/394.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #394
----
commit 4b99967b47350e2f3ef25e505bd1f523680d7f64
Author: Mars Hall <ma...@heroku.com>
Date: 2017-06-16T18:59:10Z
Extend request timeout for REST API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #394: [PIO-95] Extend request timeout fo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/394
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #394: [PIO-95] Extend request timeout fo...
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/394#discussion_r122524115
--- Diff: common/src/main/resources/application.conf ---
@@ -9,3 +9,7 @@ spray.can {
verbose-error-messages = "on"
}
}
+
+spray.can.server {
+ request-timeout = 35s
+}
--- End diff --
@mars You can put `request-timeout` inside the block above. We don't need to repeat `spray.can.server`. The configuration library will flatten the hierarchical configuration key.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #394: [PIO-95] Extend request timeout fo...
Posted by mars <gi...@git.apache.org>.
Github user mars commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/394#discussion_r122527314
--- Diff: common/src/main/resources/application.conf ---
@@ -9,3 +9,7 @@ spray.can {
verbose-error-messages = "on"
}
}
+
+spray.can.server {
+ request-timeout = 35s
+}
--- End diff --
I updated my branch with this change, but for some reason this PR is not updating to reflect the [new commit](https://github.com/mars/incubator-predictionio/commits/extend-request-timeout). Assuming it's a Github glitch which will eventually fix itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #394: [PIO-95] Extend request timeout for REST ...
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/394
@mars let's file a different JIRA for exposing engine server configuration in a generic way. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---