You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/06 05:38:41 UTC
Review Request 69905: Added a SLRP unit test for failed persistent
volume cleanup.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69905/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-9544
https://issues.apache.org/jira/browse/MESOS-9544
Repository: mesos
Description
-------
Test `ROOT_CreateDestroyPersistentMountVolumeFailed` verifies that if
SLRP fails to clean up a persistent volume, `DESTROY` would fail, the
persistent volume would remain, and depended operations will be dropped.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp e8ed20f818ed7f1a3ce15758ea3c366520443377
Diff: https://reviews.apache.org/r/69905/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 69905: Added a SLRP unit test for failed persistent
volume cleanup.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69905/#review212745
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/storage_local_resource_provider_tests.cpp
Lines 2814-2815 (patched)
<https://reviews.apache.org/r/69905/#comment298644>
Is this actually needed? With just the default filters the test still passes. Could you either remove this or document where it is needed (e.g., to address flakiness)?
- Benjamin Bannier
On Feb. 6, 2019, 6:38 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69905/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2019, 6:38 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9544
> https://issues.apache.org/jira/browse/MESOS-9544
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test `ROOT_CreateDestroyPersistentMountVolumeFailed` verifies that if
> SLRP fails to clean up a persistent volume, `DESTROY` would fail, the
> persistent volume would remain, and depended operations will be dropped.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
>
>
> Diff: https://reviews.apache.org/r/69905/diff/4/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69905: Added a SLRP unit test for failed persistent
volume cleanup.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69905/
-----------------------------------------------------------
(Updated Feb. 28, 2019, 12:24 a.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Removed unnecessary filters.
Bugs: MESOS-9565
https://issues.apache.org/jira/browse/MESOS-9565
Repository: mesos
Description
-------
Test `ROOT_CreateDestroyPersistentMountVolumeFailed` verifies that if
SLRP fails to clean up a persistent volume, `DESTROY` would fail, the
persistent volume would remain, and depended operations will be dropped.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941
Diff: https://reviews.apache.org/r/69905/diff/5/
Changes: https://reviews.apache.org/r/69905/diff/4-5/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 69905: Added a SLRP unit test for failed persistent
volume cleanup.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69905/#review212602
-----------------------------------------------------------
PASS: Mesos patch 69905 was successfully built and tested.
Reviews applied: `['69858', '69866', '69892', '69893', '69894', '69895', '69896', '69897', '69898', '69904', '69905']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2857/mesos-review-69905
- Mesos Reviewbot Windows
On Feb. 6, 2019, 1:38 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69905/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2019, 1:38 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9544
> https://issues.apache.org/jira/browse/MESOS-9544
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test `ROOT_CreateDestroyPersistentMountVolumeFailed` verifies that if
> SLRP fails to clean up a persistent volume, `DESTROY` would fail, the
> persistent volume would remain, and depended operations will be dropped.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp e8ed20f818ed7f1a3ce15758ea3c366520443377
>
>
> Diff: https://reviews.apache.org/r/69905/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>