You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2023/04/11 20:47:03 UTC

[GitHub] [maven] kwin commented on a diff in pull request #1079: [MNG-7754] Improvement and extension of plugin validation

kwin commented on code in PR #1079:
URL: https://github.com/apache/maven/pull/1079#discussion_r1163313730


##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DeprecatedCoreExpressionValidator.java:
##########
@@ -49,21 +52,32 @@ class DeprecatedCoreExpressionValidator extends AbstractMavenPluginParametersVal
         DEPRECATED_CORE_PARAMETERS = deprecatedCoreParameters;
     }
 
+    @Inject
+    DeprecatedCoreExpressionValidator(PluginValidationManager pluginValidationManager) {
+        super(pluginValidationManager);
+    }
+
     @Override
     protected String getParameterLogReason(Parameter parameter) {
-        return "is deprecated core expression; " + DEPRECATED_CORE_PARAMETERS.get(parameter.getDefaultValue());
+        return "uses deprecated parameter expression; " + DEPRECATED_CORE_PARAMETERS.get(parameter.getDefaultValue());

Review Comment:
   ```suggestion
           return "uses deprecated parameter expression '" + parameter.getDefaultValue() + "': " DEPRECATED_CORE_PARAMETERS.get(parameter.getDefaultValue());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org