You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by hivivo <gi...@git.apache.org> on 2017/08/16 23:51:12 UTC

[GitHub] helix pull request #105: [HELIX-662] Fix styling issue when visiting sites w...

GitHub user hivivo opened a pull request:

    https://github.com/apache/helix/pull/105

    [HELIX-662] Fix styling issue when visiting sites with HTTPS protocol

    When user is trying to visit helix site or docs using https protocol, the external styling files and scripts are not allowed to load into browser by default browser security limitation since the reflow-maven-skin plugin is using http CDN urls. 
    
    According to the documents here:  http://andriusvelykis.github.io/reflow-maven-skin/skin/resources.html The fix is to use local downloaded version of css and js files instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hivivo/helix master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #105
    
----
commit 50d65774fa2b741d156b37f7178cce07e2de66fc
Author: Vivo Xu <vx...@linkedin.com>
Date:   2017-08-16T23:39:44Z

    Fix styling issue when visiting sites with HTTPS protocol

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix issue #105: [HELIX-662] Fix styling issue when visiting sites with HTT...

Posted by hivivo <gi...@git.apache.org>.
Github user hivivo commented on the issue:

    https://github.com/apache/helix/pull/105
  
    tested on my local machine with valid SSL certs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request #105: [HELIX-662] Fix styling issue when visiting sites w...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/helix/pull/105


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---