[jira] [Commented] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865057#comment-17865057 ] 

ASF subversion and git services commented on OFBIZ-11947:
---------------------------------------------------------

Commit 231650e1b65a5872bb19896749e58b5781a25d41 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=231650e1b6 ]

Fixed: Trunk demo errors in error.log (OFBIZ-13005)

Found these errors:

ServerHitBin methods
  requestHistory
  eventHistory
  viewHistory
  requestSinceStarted
  eventSinceStarted
  viewSinceStarted

Don't exist. They were changed with OFBIZ-11947, but not incorporated in
StatBinsHistory and StatsSinceStart Groovy files? Here they are.


> Checkstyle: Add Javadoc for classes designed for extension
> ----------------------------------------------------------
>
>                 Key: OFBIZ-11947
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11947
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-11947-2.patch, OFBIZ-11947-3.patch, OFBIZ-11947-plugins-3.patch, OFBIZ-11947-plugins.patch, OFBIZ-11947.patch
>
>
> For checkstyle errors:
> Class 'ResourceInfo' looks like designed for extension (can be subclassed), but the method 'createResourceHandler' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'ResourceInfo' final or making the method 'createResourceHandler' static/final/abstract/empty, or adding allowed annotation for the method.
> We need to add missing javadocs for all such methods



--
This message was sent by Atlassian Jira
(v8.20.10#820010)