You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/19 10:01:27 UTC

[GitHub] [shardingsphere] tristaZero opened a new issue #7849: Support more databases for DataSourceConnectionUrlUtil

tristaZero opened a new issue #7849:
URL: https://github.com/apache/shardingsphere/issues/7849

## Introduction
`DataSourceConnectionUrlUtil` is to assemble parameters of JDBC url, e.g., password, database name, to get a complete and correct JDBC URL for the connection pool.
Presently, this class has the ability to create JDBC url for `MySQL` and `PostgreSQL` databases with `connectionSegment` and `databaseType`.
Hence, this issue is to enhance `DataSourceConnectionUrlUtil` by implementing other cases of getUrl() for `Oracle`, `SQLServer` and `MariaDB`.

## Task
- [ ] Add `switch case` for `Oracle` and create the corresponding unit case in `DataSourceConnectionUrlUtilTest`
- [ ] Add `switch case` for `SQLServer` and create the corresponding unit case in `DataSourceConnectionUrlUtilTest`
- [ ] Add `switch case` for `MariaDB` and create the corresponding unit case in `DataSourceConnectionUrlUtilTest`
## Tips
1. The case of `MySQL` in `DataSourceConnectionUrlUtil` will be a good example FYI
2. The case of `assertMySQLGetUrl()` in `DataSourceConnectionUrlUtilTest` can tell you how to add unit test
3. [Contributor guidance](https://shardingsphere.apache.org/community/cn/contribute/contributor/) is for the newbie. :-)
4. You can raise three PR for each child tasks one by one or one PR for all three case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero closed issue #7849: Support more databases for DataSourceConnectionUrlUtil

Posted by GitBox <gi...@apache.org>.

tristaZero closed issue #7849:
URL: https://github.com/apache/shardingsphere/issues/7849


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #7849: Support more databases for DataSourceConnectionUrlUtil

Posted by GitBox <gi...@apache.org>.

tristaZero commented on issue #7849:
URL: https://github.com/apache/shardingsphere/issues/7849#issuecomment-712552516


   Thanks @cenyu00, and good luck!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] cenyu00 edited a comment on issue #7849: Support more databases for DataSourceConnectionUrlUtil

Posted by GitBox <gi...@apache.org>.

cenyu00 edited a comment on issue #7849:
URL: https://github.com/apache/shardingsphere/issues/7849#issuecomment-712631285


   Hi，@tristaZero ，I submit a PR for this issues，can you review  it?  Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] cenyu00 commented on issue #7849: Support more databases for DataSourceConnectionUrlUtil

Posted by GitBox <gi...@apache.org>.

cenyu00 commented on issue #7849:
URL: https://github.com/apache/shardingsphere/issues/7849#issuecomment-712138006


   Hi  @tristaZero, I coming...
   please  assign me , I want to challenge it。 :-)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] cenyu00 commented on issue #7849: Support more databases for DataSourceConnectionUrlUtil

Posted by GitBox <gi...@apache.org>.

cenyu00 commented on issue #7849:
URL: https://github.com/apache/shardingsphere/issues/7849#issuecomment-712631285


   Hi，@tristaZero ，I submit a PR for this issues，can you review for it?  Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org