Re: svn commit: r1726928 - in /apr/apr/trunk: CMakeLists.txt SConscript include/apr_cstr.h include/apr_errno.h strings/apr_cstr.c

[Ruediger Pluem <rp...@apache.org>]

On 01/27/2016 01:08 AM, wrowe@apache.org wrote:
> Author: wrowe
> Date: Wed Jan 27 00:08:59 2016
> New Revision: 1726928
> 
> URL: http://svn.apache.org/viewvc?rev=1726928&view=rev
> Log:
> Introduce the subset of svn_cstring_ functions into APR as the apr_cstr_
> family of functions.  Requires the introduction of APR_ERANGE.
> Solves apr_cstr_casecmp[n] for ASCII and EBCDIC and borrows
> from the work of jim, ylavic and wrowe, see r1715401 forwards in;
>   http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util.c?view=log&pathrev=1722194
> More performance review is needed against different compilers, so went ahead
> and borrowed original svn implementation as a basis, and we can port whichever
> performance enhancements test out more efficiently.
> 
> Proposing for APR 1.6.0 which is the thought behind the initial @since tags.
> These must be changed if not accepted for backport.
> 
> Note that the svn_cstring_join function could not be implemented as-is
> due to the absence of svn's counted string functionality.  It deserves
> an implementation if not already present, or should be removed before
> tagging or backporting.
> 
> No whitespace/formatting cleanup on this pass in order to preserve as
> much of the svn attributions as possible.  This can happen in a later
> pass to conform to APR's style conventions.  While renaming the functions,
> declarations themsel
> 
> Added:
>     apr/apr/trunk/include/apr_cstr.h
>       - copied, changed from r1717268, subversion/trunk/subversion/include/svn_string.h
>     apr/apr/trunk/strings/apr_cstr.c
>       - copied, changed from r1717268, subversion/trunk/subversion/libsvn_subr/string.c
> Modified:
>     apr/apr/trunk/CMakeLists.txt
>     apr/apr/trunk/SConscript
>     apr/apr/trunk/include/apr_errno.h
> 

> Modified: apr/apr/trunk/SConscript
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/SConscript?rev=1726928&r1=1726927&r2=1726928&view=diff
> ==============================================================================
> --- apr/apr/trunk/SConscript (original)
> +++ apr/apr/trunk/SConscript Wed Jan 27 00:08:59 2016
> @@ -8,7 +8,7 @@ files = env.core_lib_files()
>  libapr = env.SharedLibrary('apr-%d' % (major), files)
>  tests = Split("""
>    abts.c testutil.c
> -  testtime.c teststr.c testvsn.c testipsub.c testshm.c
> +  testtime.c testcstr.c teststr.c testvsn.c testipsub.c testshm.c

I don't see any testcstr.c.

>    testmmap.c testud.c testtable.c testsleep.c testpools.c
>  	testfmt.c testfile.c testdir.c testfileinfo.c testrand.c
>  	testdso.c testoc.c testdup.c testsockets.c testproc.c
> 


Regards

Rüdiger