You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/26 02:14:10 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #26666: SFTPOperator - add support for list of file paths

uranusjr commented on code in PR #26666:
URL: https://github.com/apache/airflow/pull/26666#discussion_r979510418


##########
airflow/providers/sftp/operators/sftp.py:
##########
@@ -129,7 +143,7 @@ def __init__(
                 )
                 self.sftp_hook = SFTPHook(ssh_hook=self.ssh_hook)
 
-    def execute(self, context: Any) -> str | None:
+    def execute(self, context: Any) -> list[str] | None:

Review Comment:
   I wonder if it’d be a good idea to still return `str` if a str is passed (instead of `list[str]`). This would avoid breaking compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org