[jira] [Commented] (ROCKETMQ-104) Make MQAdmin commands throw exceptions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869605#comment-15869605 ] 

ASF GitHub Bot commented on ROCKETMQ-104:
-----------------------------------------

GitHub user shroman opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/65

    [ROCKETMQ-104] Make MQAdmin commands throw exceptions

    JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-104

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-104

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #65
    
----
commit 426b3f37686e6df05563d654493efc72e374ec40
Author: shtykh_roman <rs...@yahoo.com>
Date:   2017-02-16T09:28:20Z

    [ROCKETMQ-104] Make MQAdmin commands throw exceptions
    
    JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-104

----


> Make MQAdmin commands throw exceptions
> --------------------------------------
>
>                 Key: ROCKETMQ-104
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-104
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>
> *Why to throw exceptions?*
> With the current implementation you don't know if the command fails unless you look at console. This is one reason why errors in unit tests like in ROCKETMQ-77 can go unnoticed.
> If stack tracing is still needed, we can add logging when throwing exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)