You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/04/04 15:41:03 UTC

[GitHub] [incubator-livy] Ngone51 opened a new pull request #166: Avoid duplicate stopping log when stop/interrupt a session

Ngone51 opened a new pull request #166: Avoid duplicate stopping log when stop/interrupt a session
URL: https://github.com/apache/incubator-livy/pull/166
 
 
   ## What changes were proposed in this pull request?
   
   There's duplicate stopping log when stop/interrupt a session. This happens because server logs stopping info when we stopping/interrupting a session at the first time. And when the session expired, it would be removed from session manager and call stop() and logs stopping info for the second time(Though, it does not really stop the session again at this time).
   
   ![dup-stopping-log](https://user-images.githubusercontent.com/16397174/55568688-be0cc500-5732-11e9-9d1a-48aafcbde409.jpg)
   
   The fix is quite simple by adding a `_stopped` flag in Session's `stop()` method. 
    
   ## How was this patch tested?
   
   N.A.(?)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services