You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "hudi-bot (via GitHub)" <gi...@apache.org> on 2025/11/30 11:00:14 UTC
[I] Revisit setRecordMerger API in HoodieReaderContext [hudi]
hudi-bot opened a new issue, #16695:
URL: https://github.com/apache/hudi/issues/16695
[https://github.com/apache/hudi/pull/11943#discussion_r1805545250]
The HoodieReaderContext has the following API which takes `Option<HoodieRecordMerger>`. By design, the merge implementation class should always be non-empty. So we need to see if changing the argument type to `HoodieRecordMerger` incurs any error.
{code:java}
public void setRecordMerger(Option<HoodieRecordMerger> recordMerger) {
this.recordMerger = recordMerger;
}{code}
## JIRA info
- Link: https://issues.apache.org/jira/browse/HUDI-8417
- Type: Improvement
- Fix version(s):
- 1.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Revisit setRecordMerger API in HoodieReaderContext [hudi]
Posted by "rangareddy (via GitHub)" <gi...@apache.org>.
rangareddy commented on issue #16695:
URL: https://github.com/apache/hudi/issues/16695#issuecomment-5434698407
This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-8417).
**Findings: still open. The linked PR is merged, but it is not a fix for this.**
- #11943 - `[HUDI-8203] Make record merge mode the primary merging config` (HUDI-8203), merged 2024-10-24
Those carry a different JIRA key from this ticket - they are the change this issue was filed to follow up on. I compared each PR's content against what this ticket asks rather than relying on the key alone, and the asks are genuinely distinct, so this is a follow-up rather than a duplicate ticket.
No commit on `master` references HUDI-8417, so nothing has landed under this key.
Keeping this open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org