[jira] Commented: (MAPREDUCE-1067) Default state of queues is undefined when unspecified

["rahul k singh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786843#action_12786843 ] 

rahul k singh commented on MAPREDUCE-1067:
------------------------------------------

Queue.java
 1. In setState we are not checking if the state passed is RUNNING or STOPPED.
    Also there should be check in addChild , when we add a child , we need to check if State is changed to STOPPED or not,
   if yes we should throw an error.
   This is required as the order in which <queue> tag or <state> is not defined.

QueueConfigurationParser.java
1 . The check for queue being a container queue is not required. As we already check this in validate method , wherein we check for 
    queue tag and state tag being siblings.Can you confirm this observation?


QueueState.java
 1. We do not need a enumMap for states. 

> Default state of queues is undefined when unspecified
> -----------------------------------------------------
>
>                 Key: MAPREDUCE-1067
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1067
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.21.0
>            Reporter: V.V.Chaitanya Krishna
>            Assignee: V.V.Chaitanya Krishna
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1067-1.patch
>
>
> Currently, if the state of a queue is not specified, it is being set to "undefined" state instead of running state.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.